[llvm] unittests: ORC: Skip the ReOptimizeLayerTest for RISC-V (PR #134702)

Kashyap Chamarthy via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 7 11:27:10 PDT 2025


https://github.com/kashyapc created https://github.com/llvm/llvm-project/pull/134702

David Abdurachmanov reports[1] that we hit this error on P550 hardware:

    [...]
    /builddir/build/BUILD/llvm-20.1.1-build/llvm-project-20.1.1.src/llvm/unittests/ExecutionEngine/Orc/ReOptimizeLayerTest.cpp:140: Failure
    Value of: llvm::detail::TakeError(RM.takeError())
    Expected: succeeded
    Actual: failed (Architecture not supported) (of type llvm::detail::ErrorHolder)
    [...]

Tom Stellard noted[2] that he's seen this before on other architectures and suggested to skip it.

[1] https://src.fedoraproject.org/rpms/llvm/pull-request/408#comment-255547
[2] https://src.fedoraproject.org/rpms/llvm/pull-request/408#comment-255557

>From 4dd47d524b81a6a481a8d690d743d7c74c25af20 Mon Sep 17 00:00:00 2001
From: Kashyap Chamarthy <kchamart at redhat.com>
Date: Mon, 7 Apr 2025 17:33:54 +0200
Subject: [PATCH] unittests: ORC: Skip the ReOptimizeLayerTest for RISC-V

David Abdurachmanov reports[1] that we hit this error on P550 hardware:

    [...]
    /builddir/build/BUILD/llvm-20.1.1-build/llvm-project-20.1.1.src/llvm/unittests/ExecutionEngine/Orc/ReOptimizeLayerTest.cpp:140: Failure
    Value of: llvm::detail::TakeError(RM.takeError())
    Expected: succeeded
    Actual: failed (Architecture not supported) (of type llvm::detail::ErrorHolder)
    [...]

Tom Stellard noted[2] that he's seen this before on other architectures
and suggested to skip it.

[1] https://src.fedoraproject.org/rpms/llvm/pull-request/408#comment-255547
[2] https://src.fedoraproject.org/rpms/llvm/pull-request/408#comment-255557

Signed-off-by: Kashyap Chamarthy <kchamart at redhat.com>
---
 llvm/unittests/ExecutionEngine/Orc/ReOptimizeLayerTest.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/llvm/unittests/ExecutionEngine/Orc/ReOptimizeLayerTest.cpp b/llvm/unittests/ExecutionEngine/Orc/ReOptimizeLayerTest.cpp
index 78dc0f24c0f99..a7edac29d1e99 100644
--- a/llvm/unittests/ExecutionEngine/Orc/ReOptimizeLayerTest.cpp
+++ b/llvm/unittests/ExecutionEngine/Orc/ReOptimizeLayerTest.cpp
@@ -55,6 +55,10 @@ class ReOptimizeLayerTest : public testing::Test {
     if (Triple.isPPC())
       GTEST_SKIP();
 
+    // RISC-V is not supported yet
+    if (Triple.isRISCV())
+      GTEST_SKIP();
+
     auto EPC = SelfExecutorProcessControl::Create();
     if (!EPC) {
       consumeError(EPC.takeError());



More information about the llvm-commits mailing list