[llvm] [AMDGPU] SIInstrInfo: Fix resultDependsOnExec for VOPC instructions (PR #134629)
Frederik Harwath via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 7 07:35:30 PDT 2025
================
@@ -151,6 +151,9 @@ static bool resultDependsOnExec(const MachineInstr &MI) {
// Ignore comparisons which are only used masked with exec.
// This allows some hoisting/sinking of VALU comparisons.
if (MI.isCompare()) {
+ if (SIInstrInfo::isVOPC(MI))
----------------
frederik-h wrote:
> Probably should directly check the first operand is the only explicit def rather than assume it's implied by the encoding
I have adjusted the condition. The downside is that it's less clear to me now if returning false is correct for all instructions covered by this condition.
https://github.com/llvm/llvm-project/pull/134629
More information about the llvm-commits
mailing list