[llvm] [SPIRV][NFC] Refactor pointer creation in GlobalRegistery (PR #134429)

Nathan Gauër via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 7 05:48:11 PDT 2025


================
@@ -466,6 +466,14 @@ class SPIRVGlobalRegistry : public SPIRVIRMapping {
                                          Constant *CA, unsigned BitWidth,
                                          unsigned ElemCnt);
 
+  // Returns a pointer to a SPIR-V pointer type with the given base type and
+  // storage class. It is the responsibility of the caller to make sure the
+  // decorations on the base type are valid for the given storage class. For
+  // example, it has the correct offset and stride decorations.
+  SPIRVType *getOrCreateSPIRVPointerTypeInternal(
+      SPIRVType *BaseType, MachineIRBuilder &MIRBuilder,
+      SPIRV::StorageClass::StorageClass SClass = SPIRV::StorageClass::Function);
----------------
Keenuts wrote:

Default value is never used, remove?

https://github.com/llvm/llvm-project/pull/134429


More information about the llvm-commits mailing list