[llvm] [AMDGPU] Simplify emitAtomicRMWLegalRemark. NFC. (PR #134614)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 7 04:18:33 PDT 2025


https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/134614

None

>From 2d635cb17dea1b5a9d281da160a6e0f87ef59e8d Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Mon, 7 Apr 2025 12:02:53 +0100
Subject: [PATCH] [AMDGPU] Simplify emitAtomicRMWLegalRemark. NFC.

---
 llvm/lib/Target/AMDGPU/SIISelLowering.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 21f8c7cfeec1f..356040da95672 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -16723,8 +16723,8 @@ static bool atomicIgnoresDenormalModeOrFPModeIsFTZ(const AtomicRMWInst *RMW) {
 
 static OptimizationRemark emitAtomicRMWLegalRemark(const AtomicRMWInst *RMW) {
   LLVMContext &Ctx = RMW->getContext();
-  StringRef SS = Ctx.getSyncScopeName(RMW->getSyncScopeID()).value_or("");
-  StringRef MemScope = SS.empty() ? StringRef("system") : SS;
+  StringRef MemScope =
+      Ctx.getSyncScopeName(RMW->getSyncScopeID()).value_or("system");
 
   return OptimizationRemark(DEBUG_TYPE, "Passed", RMW)
          << "Hardware instruction generated for atomic "



More information about the llvm-commits mailing list