[llvm] llvm-reduce: Make some error messages more consistent (PR #133563)

[Matt Arsenault via llvm-commits]

https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/133563

>From 93eac74792af8b959797cad1cf646cc4e23192bc Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: Sat, 29 Mar 2025 10:49:35 +0700
Subject: [PATCH 1/2] llvm-reduce: Make some error messages more consistent

The coding standards states that error messages should start with
a lowercase. Also use WithColor, and add missing test coverage for
the failed to write to output file case.
---
 llvm/test/tools/llvm-reduce/fail-execute-test.test | 2 +-
 llvm/test/tools/llvm-reduce/fail-output-file.test  | 7 +++++++
 llvm/tools/llvm-reduce/TestRunner.cpp              | 8 ++++----
 3 files changed, 12 insertions(+), 5 deletions(-)
 create mode 100644 llvm/test/tools/llvm-reduce/fail-output-file.test

diff --git a/llvm/test/tools/llvm-reduce/fail-execute-test.test b/llvm/test/tools/llvm-reduce/fail-execute-test.test
index f60107f97327f..1b3266e72ad21 100644
--- a/llvm/test/tools/llvm-reduce/fail-execute-test.test
+++ b/llvm/test/tools/llvm-reduce/fail-execute-test.test
@@ -1,4 +1,4 @@
 # RUN: export LSAN_OPTIONS=detect_leaks=0
 # RUN: not llvm-reduce --test=%s.NotAFileInTestingDir %p/Inputs/test-output-format.ll 2>&1 | FileCheck -DFILENAME=%s.NotAFileInTestingDir --strict-whitespace %s
 
-# CHECK: Error running interesting-ness test: {{(Executable "[[FILENAME]]" doesn't exist$)?(program not executable$)?}}
+# CHECK: error: running interesting-ness test: {{(Executable "[[FILENAME]]" doesn't exist$)?(program not executable$)?}}
diff --git a/llvm/test/tools/llvm-reduce/fail-output-file.test b/llvm/test/tools/llvm-reduce/fail-output-file.test
new file mode 100644
index 0000000000000..2f3536df06994
--- /dev/null
+++ b/llvm/test/tools/llvm-reduce/fail-output-file.test
@@ -0,0 +1,7 @@
+# Python on an empty file will always succeed as interesting
+# RUN: touch %t
+
+# Fail on attempt to write to output directory
+# RUN: not llvm-reduce --delta-passes=instructions -o %s/CannotOpenFile --test %python --test-arg %t %p/Inputs/test-output-format.ll 2>&1 | FileCheck %s
+
+# CHECK: error: opening output file: Not a directory
diff --git a/llvm/tools/llvm-reduce/TestRunner.cpp b/llvm/tools/llvm-reduce/TestRunner.cpp
index aac5c4a4fe7a6..ad9f925ebccc7 100644
--- a/llvm/tools/llvm-reduce/TestRunner.cpp
+++ b/llvm/tools/llvm-reduce/TestRunner.cpp
@@ -45,9 +45,8 @@ int TestRunner::run(StringRef Filename) const {
                           /*SecondsToWait=*/0, /*MemoryLimit=*/0, &ErrMsg);
 
   if (Result < 0) {
-    Error E = make_error<StringError>("Error running interesting-ness test: " +
-                                          ErrMsg,
-                                      inconvertibleErrorCode());
+    Error E = make_error<StringError>(
+        "running interesting-ness test: " + ErrMsg, inconvertibleErrorCode());
     WithColor::error(errs(), ToolName) << toString(std::move(E)) << '\n';
     exit(1);
   }
@@ -61,7 +60,8 @@ void TestRunner::writeOutput(StringRef Message) {
                      EmitBitcode && !Program->isMIR() ? sys::fs::OF_None
                                                       : sys::fs::OF_Text);
   if (EC) {
-    errs() << "Error opening output file: " << EC.message() << "!\n";
+    WithColor::error(errs(), ToolName)
+        << "opening output file: " << EC.message() << '\n';
     exit(1);
   }
 

>From b102b37e28e5433c4fa5987b3337acc4f750f166 Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault at amd.com>
Date: Sat, 29 Mar 2025 12:47:51 +0700
Subject: [PATCH 2/2] Change invalid test error to avoid windows bot failures

---
 llvm/test/tools/llvm-reduce/fail-output-file.test | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/llvm/test/tools/llvm-reduce/fail-output-file.test b/llvm/test/tools/llvm-reduce/fail-output-file.test
index 2f3536df06994..76965703cbe25 100644
--- a/llvm/test/tools/llvm-reduce/fail-output-file.test
+++ b/llvm/test/tools/llvm-reduce/fail-output-file.test
@@ -1,7 +1,7 @@
 # Python on an empty file will always succeed as interesting
 # RUN: touch %t
 
-# Fail on attempt to write to output directory
-# RUN: not llvm-reduce --delta-passes=instructions -o %s/CannotOpenFile --test %python --test-arg %t %p/Inputs/test-output-format.ll 2>&1 | FileCheck %s
+# Fail on attempt to write output to a directory
+# RUN: not llvm-reduce --delta-passes=instructions -o %p/Inputs --test %python --test-arg %t %p/Inputs/test-output-format.ll 2>&1 | FileCheck  -DMSG=%errc_EISDIR %s
 
-# CHECK: error: opening output file: Not a directory
+# CHECK: error: opening output file: [[MSG]]