[clang] [llvm] [HLSL][SPIR-V] Add hlsl_private address space for SPIR-V (PR #133464)

[Steven Perron via llvm-commits]

================
@@ -5150,6 +5152,9 @@ bool Type::isHLSLIntangibleType() const {
   CXXRecordDecl *RD = RT->getAsCXXRecordDecl();
   assert(RD != nullptr &&
          "all HLSL structs and classes should be CXXRecordDecl");
+
+  if (!RD->isCompleteDefinition())
+    return false;
   assert(RD->isCompleteDefinition() && "expecting complete type");
----------------
s-perron wrote:

Why leave the assert? A comment explaining how you know an incomplete definition is not an intangible type would be useful.

https://github.com/llvm/llvm-project/pull/133464