[clang] [llvm] [clang][CodeGen] Generate follow-up metadata for loops in correct format (PR #131985)

Ryotaro Kasuga via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 28 07:51:34 PDT 2025


================
@@ -44,23 +44,19 @@ MDNode *LoopInfo::createPipeliningMetadata(const LoopAttributes &Attrs,
   else if (Attrs.PipelineInitiationInterval != 0)
     Enabled = true;
 
+  SmallVector<Metadata *, 4> Args;
+  Args.append(LoopProperties.begin(), LoopProperties.end());
+
   if (Enabled != true) {
-    SmallVector<Metadata *, 4> NewLoopProperties;
     if (Enabled == false) {
-      NewLoopProperties.append(LoopProperties.begin(), LoopProperties.end());
----------------
kasuga-fj wrote:

> I think this is due to the regex .* being too greedy, so e.g. ![[ISVECTORIZED:.*]] consumes multiple metadata nodes.

That makes sense! I got it, thank you!

> Another one is that by default `CHECK: pet store` will match `carpet store`.

Ugh, that's a tricky problem.

https://github.com/llvm/llvm-project/pull/131985


More information about the llvm-commits mailing list