[llvm] Revert "Fix gcc signed/unsigned comparison warning. NFC." (PR #133334)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-x86

Author: Walter Lee (googlewalt)

<details>
<summary>Changes</summary>

This reverts commit 6c2171672f03356835c534a0ec18250233ea66db. It touches a common file as #<!-- -->133083, which is causing failures

---
Full diff: https://github.com/llvm/llvm-project/pull/133334.diff


1 Files Affected:

- (modified) llvm/lib/Target/X86/X86ISelLowering.cpp (+1-1) 


``````````diff
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index a514e7f1ab48c..81c75a2f98079 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -58959,7 +58959,7 @@ static SDValue combineINSERT_SUBVECTOR(SDNode *N, SelectionDAG &DAG,
   // If we're splatting the lower half subvector of a full vector load into the
   // upper half, attempt to create a subvector broadcast.
   // TODO: Drop hasOneUse checks.
-  if ((int)IdxVal == (VecNumElts / 2) &&
+  if (IdxVal == (VecNumElts / 2) &&
       Vec.getValueSizeInBits() == (2 * SubVec.getValueSizeInBits()) &&
       (Vec.hasOneUse() || SubVec.hasOneUse())) {
     auto *VecLd = dyn_cast<LoadSDNode>(Vec);

``````````

</details>


https://github.com/llvm/llvm-project/pull/133334