[llvm] [HLSL] Analyze update counter usage (PR #130356)

[Ashley Coleman via llvm-commits]

V-FEXrt wrote:

After some offline discussions with @hekota and @bogner, it was decided that it's better to have one pass do the analysis and a separate "errors" pass that actually raises Diags, not just for this error but other classes of DXIL errors as well.

With that in mind I'm going to put up another patch that decreases the scope of this change then later push up a PR for handling/raising the Diag

https://github.com/llvm/llvm-project/pull/130356