[llvm] [BOLT][AArch64] Partial support for lite mode (PR #133014)

[Maksim Panchenko via llvm-commits]

================
@@ -1673,12 +1678,104 @@ bool BinaryFunction::scanExternalRefs() {
     if (BranchTargetSymbol) {
       BC.MIB->replaceBranchTarget(Instruction, BranchTargetSymbol,
                                   Emitter.LocalCtx.get());
-    } else if (!llvm::any_of(Instruction,
-                             [](const MCOperand &Op) { return Op.isExpr(); })) {
-      // Skip assembly if the instruction may not have any symbolic operands.
-      continue;
     } else {
+      bool NeedsPatch = false;
       analyzeInstructionForFuncReference(Instruction);
+      for (unsigned OpNum = 0; OpNum < MCPlus::getNumPrimeOperands(Instruction);
+           ++OpNum) {
+        const MCSymbol *Symbol = BC.MIB->getTargetSymbol(Instruction, OpNum);
+        if (!Symbol)
+          continue;
+        if (!ignoreReference(Symbol)) {
+          NeedsPatch = true;
+          break;
+        }
+      }
+      if (!NeedsPatch)
+        continue;
+    }
+
+    // For AArch64, we need to undo relaxation done by the linker if the target
+    // of the instruction is a function that we plan to move.
+    const Relocation *Rel;
+    if (BC.isAArch64() && (Rel = getRelocationAt(Offset))) {
----------------
maksfb wrote:

I'd prefer not to execute `getRelocationAt()` unless we are under `BC.isAArch64()`. Ugly as it is, I'll move `Rel` declaration under `if ()`.

https://github.com/llvm/llvm-project/pull/133014