[lld] [lld] Merge GOT entries for symbols that have been ICFed (PR #131630)
Pranav Kant via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 26 15:22:14 PDT 2025
https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/131630
>From 69ee9dbea959a41cb5615b923a8f0a0e4cf9758f Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Mon, 17 Mar 2025 02:09:44 +0000
Subject: [PATCH 1/9] [lld] Merge GOT entries for symbols that have been ICFed
This becomes a problem for AArch64 when ADRP and LDR instructions
are outlined in separate sections. See test case for details.
---
lld/ELF/SyntheticSections.cpp | 13 +
lld/ELF/SyntheticSections.h | 3 +
lld/test/ELF/aarch64-adrp-ldr-icf.s | 1057 +++++++++++++++++++++++++++
3 files changed, 1073 insertions(+)
create mode 100644 lld/test/ELF/aarch64-adrp-ldr-icf.s
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index b03c4282ab1aa..a22bf2cece61a 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -667,6 +667,19 @@ GotSection::GotSection(Ctx &ctx)
void GotSection::addConstant(const Relocation &r) { relocations.push_back(r); }
void GotSection::addEntry(const Symbol &sym) {
assert(sym.auxIdx == ctx.symAux.size() - 1);
+ if (auto *d = dyn_cast<Defined>(&sym)) {
+ // There may be symbols that have been ICFed in which case d->section
+ // points to their canonical section and d->value is offset in to that section.
+ // We add only a single GOT entry for all such symbols.
+ auto [it, inserted] = gotEntries.insert(
+ std::make_pair(std::make_pair(d->section, d->value),
+ numEntries));
+ if (!inserted) {
+ ctx.symAux.back().gotIdx = it->getSecond();
+ return;
+ }
+ }
+
ctx.symAux.back().gotIdx = numEntries++;
}
diff --git a/lld/ELF/SyntheticSections.h b/lld/ELF/SyntheticSections.h
index c977562f0b174..3debb08e4dd2b 100644
--- a/lld/ELF/SyntheticSections.h
+++ b/lld/ELF/SyntheticSections.h
@@ -138,6 +138,9 @@ class GotSection final : public SyntheticSection {
bool isSymbolFunc;
};
SmallVector<AuthEntryInfo, 0> authEntries;
+
+ // To track GOT entries for symbols that may have been ICFed
+ llvm::DenseMap<std::pair<SectionBase*, uint64_t>, uint32_t> gotEntries;
};
// .note.GNU-stack section.
diff --git a/lld/test/ELF/aarch64-adrp-ldr-icf.s b/lld/test/ELF/aarch64-adrp-ldr-icf.s
new file mode 100644
index 0000000000000..fa8167cd12c87
--- /dev/null
+++ b/lld/test/ELF/aarch64-adrp-ldr-icf.s
@@ -0,0 +1,1057 @@
+// REQUIRES: aarch64
+
+// RUN: llvm-mc -filetype=obj -triple=aarch64 %s -o %t
+// RUN: ld.lld %t -o %t2 --icf=all
+// RUN: llvm-objdump --section-headers %t2 | FileCheck %s
+
+// CHECK: {{.*}}.got 00000008{{.*}}
+
+.addrsig
+
+callee:
+ret
+
+.section .rodata.dummy1,"a", at progbits
+sym1:
+.long 111
+.long 122
+.byte 123
+
+.section .rodata.dummy2,"a", at progbits
+sym2:
+.long 111
+.long 122
+sym3:
+.byte 123
+
+.macro f, index
+
+.section .text.f1_\index,"ax", at progbits
+f1_\index:
+adrp x0, :got:g\index
+mov x1, #\index
+b f2_\index
+
+.section .text.f2_\index,"ax", at progbits
+f2_\index:
+ldr x0, [x0, :got_lo12:g\index]
+b callee
+
+.section .rodata.g\index,"a", at progbits
+g_\index:
+.long 111
+.long 122
+
+g\index:
+.byte 123
+
+.section .text._start,"ax", at progbits
+bl f1_\index
+
+.endm
+
+.section .text._start,"ax", at progbits
+.globl _start
+_start:
+
+f 0
+f 1
+f 2
+f 3
+f 4
+f 5
+f 6
+f 7
+f 8
+f 9
+f 10
+f 11
+f 12
+f 13
+f 14
+f 15
+f 16
+f 17
+f 18
+f 19
+f 20
+f 21
+f 22
+f 23
+f 24
+f 25
+f 26
+f 27
+f 28
+f 29
+f 30
+f 31
+f 32
+f 33
+f 34
+f 35
+f 36
+f 37
+f 38
+f 39
+f 40
+f 41
+f 42
+f 43
+f 44
+f 45
+f 46
+f 47
+f 48
+f 49
+f 50
+f 51
+f 52
+f 53
+f 54
+f 55
+f 56
+f 57
+f 58
+f 59
+f 60
+f 61
+f 62
+f 63
+f 64
+f 65
+f 66
+f 67
+f 68
+f 69
+f 70
+f 71
+f 72
+f 73
+f 74
+f 75
+f 76
+f 77
+f 78
+f 79
+f 80
+f 81
+f 82
+f 83
+f 84
+f 85
+f 86
+f 87
+f 88
+f 89
+f 90
+f 91
+f 92
+f 93
+f 94
+f 95
+f 96
+f 97
+f 98
+f 99
+f 100
+f 101
+f 102
+f 103
+f 104
+f 105
+f 106
+f 107
+f 108
+f 109
+f 110
+f 111
+f 112
+f 113
+f 114
+f 115
+f 116
+f 117
+f 118
+f 119
+f 120
+f 121
+f 122
+f 123
+f 124
+f 125
+f 126
+f 127
+f 128
+f 129
+f 130
+f 131
+f 132
+f 133
+f 134
+f 135
+f 136
+f 137
+f 138
+f 139
+f 140
+f 141
+f 142
+f 143
+f 144
+f 145
+f 146
+f 147
+f 148
+f 149
+f 150
+f 151
+f 152
+f 153
+f 154
+f 155
+f 156
+f 157
+f 158
+f 159
+f 160
+f 161
+f 162
+f 163
+f 164
+f 165
+f 166
+f 167
+f 168
+f 169
+f 170
+f 171
+f 172
+f 173
+f 174
+f 175
+f 176
+f 177
+f 178
+f 179
+f 180
+f 181
+f 182
+f 183
+f 184
+f 185
+f 186
+f 187
+f 188
+f 189
+f 190
+f 191
+f 192
+f 193
+f 194
+f 195
+f 196
+f 197
+f 198
+f 199
+f 200
+f 201
+f 202
+f 203
+f 204
+f 205
+f 206
+f 207
+f 208
+f 209
+f 210
+f 211
+f 212
+f 213
+f 214
+f 215
+f 216
+f 217
+f 218
+f 219
+f 220
+f 221
+f 222
+f 223
+f 224
+f 225
+f 226
+f 227
+f 228
+f 229
+f 230
+f 231
+f 232
+f 233
+f 234
+f 235
+f 236
+f 237
+f 238
+f 239
+f 240
+f 241
+f 242
+f 243
+f 244
+f 245
+f 246
+f 247
+f 248
+f 249
+f 250
+f 251
+f 252
+f 253
+f 254
+f 255
+f 256
+f 257
+f 258
+f 259
+f 260
+f 261
+f 262
+f 263
+f 264
+f 265
+f 266
+f 267
+f 268
+f 269
+f 270
+f 271
+f 272
+f 273
+f 274
+f 275
+f 276
+f 277
+f 278
+f 279
+f 280
+f 281
+f 282
+f 283
+f 284
+f 285
+f 286
+f 287
+f 288
+f 289
+f 290
+f 291
+f 292
+f 293
+f 294
+f 295
+f 296
+f 297
+f 298
+f 299
+f 300
+f 301
+f 302
+f 303
+f 304
+f 305
+f 306
+f 307
+f 308
+f 309
+f 310
+f 311
+f 312
+f 313
+f 314
+f 315
+f 316
+f 317
+f 318
+f 319
+f 320
+f 321
+f 322
+f 323
+f 324
+f 325
+f 326
+f 327
+f 328
+f 329
+f 330
+f 331
+f 332
+f 333
+f 334
+f 335
+f 336
+f 337
+f 338
+f 339
+f 340
+f 341
+f 342
+f 343
+f 344
+f 345
+f 346
+f 347
+f 348
+f 349
+f 350
+f 351
+f 352
+f 353
+f 354
+f 355
+f 356
+f 357
+f 358
+f 359
+f 360
+f 361
+f 362
+f 363
+f 364
+f 365
+f 366
+f 367
+f 368
+f 369
+f 370
+f 371
+f 372
+f 373
+f 374
+f 375
+f 376
+f 377
+f 378
+f 379
+f 380
+f 381
+f 382
+f 383
+f 384
+f 385
+f 386
+f 387
+f 388
+f 389
+f 390
+f 391
+f 392
+f 393
+f 394
+f 395
+f 396
+f 397
+f 398
+f 399
+f 400
+f 401
+f 402
+f 403
+f 404
+f 405
+f 406
+f 407
+f 408
+f 409
+f 410
+f 411
+f 412
+f 413
+f 414
+f 415
+f 416
+f 417
+f 418
+f 419
+f 420
+f 421
+f 422
+f 423
+f 424
+f 425
+f 426
+f 427
+f 428
+f 429
+f 430
+f 431
+f 432
+f 433
+f 434
+f 435
+f 436
+f 437
+f 438
+f 439
+f 440
+f 441
+f 442
+f 443
+f 444
+f 445
+f 446
+f 447
+f 448
+f 449
+f 450
+f 451
+f 452
+f 453
+f 454
+f 455
+f 456
+f 457
+f 458
+f 459
+f 460
+f 461
+f 462
+f 463
+f 464
+f 465
+f 466
+f 467
+f 468
+f 469
+f 470
+f 471
+f 472
+f 473
+f 474
+f 475
+f 476
+f 477
+f 478
+f 479
+f 480
+f 481
+f 482
+f 483
+f 484
+f 485
+f 486
+f 487
+f 488
+f 489
+f 490
+f 491
+f 492
+f 493
+f 494
+f 495
+f 496
+f 497
+f 498
+f 499
+f 500
+f 501
+f 502
+f 503
+f 504
+f 505
+f 506
+f 507
+f 508
+f 509
+f 510
+f 511
+f 512
+f 513
+f 514
+f 515
+f 516
+f 517
+f 518
+f 519
+f 520
+f 521
+f 522
+f 523
+f 524
+f 525
+f 526
+f 527
+f 528
+f 529
+f 530
+f 531
+f 532
+f 533
+f 534
+f 535
+f 536
+f 537
+f 538
+f 539
+f 540
+f 541
+f 542
+f 543
+f 544
+f 545
+f 546
+f 547
+f 548
+f 549
+f 550
+f 551
+f 552
+f 553
+f 554
+f 555
+f 556
+f 557
+f 558
+f 559
+f 560
+f 561
+f 562
+f 563
+f 564
+f 565
+f 566
+f 567
+f 568
+f 569
+f 570
+f 571
+f 572
+f 573
+f 574
+f 575
+f 576
+f 577
+f 578
+f 579
+f 580
+f 581
+f 582
+f 583
+f 584
+f 585
+f 586
+f 587
+f 588
+f 589
+f 590
+f 591
+f 592
+f 593
+f 594
+f 595
+f 596
+f 597
+f 598
+f 599
+f 600
+f 601
+f 602
+f 603
+f 604
+f 605
+f 606
+f 607
+f 608
+f 609
+f 610
+f 611
+f 612
+f 613
+f 614
+f 615
+f 616
+f 617
+f 618
+f 619
+f 620
+f 621
+f 622
+f 623
+f 624
+f 625
+f 626
+f 627
+f 628
+f 629
+f 630
+f 631
+f 632
+f 633
+f 634
+f 635
+f 636
+f 637
+f 638
+f 639
+f 640
+f 641
+f 642
+f 643
+f 644
+f 645
+f 646
+f 647
+f 648
+f 649
+f 650
+f 651
+f 652
+f 653
+f 654
+f 655
+f 656
+f 657
+f 658
+f 659
+f 660
+f 661
+f 662
+f 663
+f 664
+f 665
+f 666
+f 667
+f 668
+f 669
+f 670
+f 671
+f 672
+f 673
+f 674
+f 675
+f 676
+f 677
+f 678
+f 679
+f 680
+f 681
+f 682
+f 683
+f 684
+f 685
+f 686
+f 687
+f 688
+f 689
+f 690
+f 691
+f 692
+f 693
+f 694
+f 695
+f 696
+f 697
+f 698
+f 699
+f 700
+f 701
+f 702
+f 703
+f 704
+f 705
+f 706
+f 707
+f 708
+f 709
+f 710
+f 711
+f 712
+f 713
+f 714
+f 715
+f 716
+f 717
+f 718
+f 719
+f 720
+f 721
+f 722
+f 723
+f 724
+f 725
+f 726
+f 727
+f 728
+f 729
+f 730
+f 731
+f 732
+f 733
+f 734
+f 735
+f 736
+f 737
+f 738
+f 739
+f 740
+f 741
+f 742
+f 743
+f 744
+f 745
+f 746
+f 747
+f 748
+f 749
+f 750
+f 751
+f 752
+f 753
+f 754
+f 755
+f 756
+f 757
+f 758
+f 759
+f 760
+f 761
+f 762
+f 763
+f 764
+f 765
+f 766
+f 767
+f 768
+f 769
+f 770
+f 771
+f 772
+f 773
+f 774
+f 775
+f 776
+f 777
+f 778
+f 779
+f 780
+f 781
+f 782
+f 783
+f 784
+f 785
+f 786
+f 787
+f 788
+f 789
+f 790
+f 791
+f 792
+f 793
+f 794
+f 795
+f 796
+f 797
+f 798
+f 799
+f 800
+f 801
+f 802
+f 803
+f 804
+f 805
+f 806
+f 807
+f 808
+f 809
+f 810
+f 811
+f 812
+f 813
+f 814
+f 815
+f 816
+f 817
+f 818
+f 819
+f 820
+f 821
+f 822
+f 823
+f 824
+f 825
+f 826
+f 827
+f 828
+f 829
+f 830
+f 831
+f 832
+f 833
+f 834
+f 835
+f 836
+f 837
+f 838
+f 839
+f 840
+f 841
+f 842
+f 843
+f 844
+f 845
+f 846
+f 847
+f 848
+f 849
+f 850
+f 851
+f 852
+f 853
+f 854
+f 855
+f 856
+f 857
+f 858
+f 859
+f 860
+f 861
+f 862
+f 863
+f 864
+f 865
+f 866
+f 867
+f 868
+f 869
+f 870
+f 871
+f 872
+f 873
+f 874
+f 875
+f 876
+f 877
+f 878
+f 879
+f 880
+f 881
+f 882
+f 883
+f 884
+f 885
+f 886
+f 887
+f 888
+f 889
+f 890
+f 891
+f 892
+f 893
+f 894
+f 895
+f 896
+f 897
+f 898
+f 899
+f 900
+f 901
+f 902
+f 903
+f 904
+f 905
+f 906
+f 907
+f 908
+f 909
+f 910
+f 911
+f 912
+f 913
+f 914
+f 915
+f 916
+f 917
+f 918
+f 919
+f 920
+f 921
+f 922
+f 923
+f 924
+f 925
+f 926
+f 927
+f 928
+f 929
+f 930
+f 931
+f 932
+f 933
+f 934
+f 935
+f 936
+f 937
+f 938
+f 939
+f 940
+f 941
+f 942
+f 943
+f 944
+f 945
+f 946
+f 947
+f 948
+f 949
+f 950
+f 951
+f 952
+f 953
+f 954
+f 955
+f 956
+f 957
+f 958
+f 959
+f 960
+f 961
+f 962
+f 963
+f 964
+f 965
+f 966
+f 967
+f 968
+f 969
+f 970
+f 971
+f 972
+f 973
+f 974
+f 975
+f 976
+f 977
+f 978
+f 979
+f 980
+f 981
+f 982
+f 983
+f 984
+f 985
+f 986
+f 987
+f 988
+f 989
+f 990
+f 991
+f 992
+f 993
+f 994
+f 995
+f 996
+f 997
+f 998
+f 999
+f 1000
>From 4c472d1f927e5450f9310c81da2dfefda11eee4f Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Mon, 17 Mar 2025 16:59:53 +0000
Subject: [PATCH 2/9] ICF conditional
---
lld/ELF/SyntheticSections.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index a22bf2cece61a..433b86aa9abd9 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -667,14 +667,15 @@ GotSection::GotSection(Ctx &ctx)
void GotSection::addConstant(const Relocation &r) { relocations.push_back(r); }
void GotSection::addEntry(const Symbol &sym) {
assert(sym.auxIdx == ctx.symAux.size() - 1);
- if (auto *d = dyn_cast<Defined>(&sym)) {
+ auto *d = dyn_cast<Defined>(&sym);
+ if (d && ctx.arg.icf != ICFLevel::None) {
// There may be symbols that have been ICFed in which case d->section
// points to their canonical section and d->value is offset in to that section.
// We add only a single GOT entry for all such symbols.
auto [it, inserted] = gotEntries.insert(
std::make_pair(std::make_pair(d->section, d->value),
numEntries));
- if (!inserted) {
+ if (!inserted && d->folded) {
ctx.symAux.back().gotIdx = it->getSecond();
return;
}
>From b8ebd154f12a8cfa7e3babfa5b3ca1ea4fe59a89 Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Tue, 18 Mar 2025 19:29:17 +0000
Subject: [PATCH 3/9] review
---
lld/ELF/SyntheticSections.cpp | 4 +-
lld/test/ELF/aarch64-adrp-ldr-icf.s | 1001 +--------------------------
2 files changed, 3 insertions(+), 1002 deletions(-)
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index 433b86aa9abd9..a97203a7ae79a 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -668,14 +668,14 @@ void GotSection::addConstant(const Relocation &r) { relocations.push_back(r); }
void GotSection::addEntry(const Symbol &sym) {
assert(sym.auxIdx == ctx.symAux.size() - 1);
auto *d = dyn_cast<Defined>(&sym);
- if (d && ctx.arg.icf != ICFLevel::None) {
+ if (d && !d->isPreemptible && ctx.arg.icf != ICFLevel::None) {
// There may be symbols that have been ICFed in which case d->section
// points to their canonical section and d->value is offset in to that section.
// We add only a single GOT entry for all such symbols.
auto [it, inserted] = gotEntries.insert(
std::make_pair(std::make_pair(d->section, d->value),
numEntries));
- if (!inserted && d->folded) {
+ if (!inserted) {
ctx.symAux.back().gotIdx = it->getSecond();
return;
}
diff --git a/lld/test/ELF/aarch64-adrp-ldr-icf.s b/lld/test/ELF/aarch64-adrp-ldr-icf.s
index fa8167cd12c87..f6dd47f204148 100644
--- a/lld/test/ELF/aarch64-adrp-ldr-icf.s
+++ b/lld/test/ELF/aarch64-adrp-ldr-icf.s
@@ -55,1003 +55,4 @@ bl f1_\index
_start:
f 0
-f 1
-f 2
-f 3
-f 4
-f 5
-f 6
-f 7
-f 8
-f 9
-f 10
-f 11
-f 12
-f 13
-f 14
-f 15
-f 16
-f 17
-f 18
-f 19
-f 20
-f 21
-f 22
-f 23
-f 24
-f 25
-f 26
-f 27
-f 28
-f 29
-f 30
-f 31
-f 32
-f 33
-f 34
-f 35
-f 36
-f 37
-f 38
-f 39
-f 40
-f 41
-f 42
-f 43
-f 44
-f 45
-f 46
-f 47
-f 48
-f 49
-f 50
-f 51
-f 52
-f 53
-f 54
-f 55
-f 56
-f 57
-f 58
-f 59
-f 60
-f 61
-f 62
-f 63
-f 64
-f 65
-f 66
-f 67
-f 68
-f 69
-f 70
-f 71
-f 72
-f 73
-f 74
-f 75
-f 76
-f 77
-f 78
-f 79
-f 80
-f 81
-f 82
-f 83
-f 84
-f 85
-f 86
-f 87
-f 88
-f 89
-f 90
-f 91
-f 92
-f 93
-f 94
-f 95
-f 96
-f 97
-f 98
-f 99
-f 100
-f 101
-f 102
-f 103
-f 104
-f 105
-f 106
-f 107
-f 108
-f 109
-f 110
-f 111
-f 112
-f 113
-f 114
-f 115
-f 116
-f 117
-f 118
-f 119
-f 120
-f 121
-f 122
-f 123
-f 124
-f 125
-f 126
-f 127
-f 128
-f 129
-f 130
-f 131
-f 132
-f 133
-f 134
-f 135
-f 136
-f 137
-f 138
-f 139
-f 140
-f 141
-f 142
-f 143
-f 144
-f 145
-f 146
-f 147
-f 148
-f 149
-f 150
-f 151
-f 152
-f 153
-f 154
-f 155
-f 156
-f 157
-f 158
-f 159
-f 160
-f 161
-f 162
-f 163
-f 164
-f 165
-f 166
-f 167
-f 168
-f 169
-f 170
-f 171
-f 172
-f 173
-f 174
-f 175
-f 176
-f 177
-f 178
-f 179
-f 180
-f 181
-f 182
-f 183
-f 184
-f 185
-f 186
-f 187
-f 188
-f 189
-f 190
-f 191
-f 192
-f 193
-f 194
-f 195
-f 196
-f 197
-f 198
-f 199
-f 200
-f 201
-f 202
-f 203
-f 204
-f 205
-f 206
-f 207
-f 208
-f 209
-f 210
-f 211
-f 212
-f 213
-f 214
-f 215
-f 216
-f 217
-f 218
-f 219
-f 220
-f 221
-f 222
-f 223
-f 224
-f 225
-f 226
-f 227
-f 228
-f 229
-f 230
-f 231
-f 232
-f 233
-f 234
-f 235
-f 236
-f 237
-f 238
-f 239
-f 240
-f 241
-f 242
-f 243
-f 244
-f 245
-f 246
-f 247
-f 248
-f 249
-f 250
-f 251
-f 252
-f 253
-f 254
-f 255
-f 256
-f 257
-f 258
-f 259
-f 260
-f 261
-f 262
-f 263
-f 264
-f 265
-f 266
-f 267
-f 268
-f 269
-f 270
-f 271
-f 272
-f 273
-f 274
-f 275
-f 276
-f 277
-f 278
-f 279
-f 280
-f 281
-f 282
-f 283
-f 284
-f 285
-f 286
-f 287
-f 288
-f 289
-f 290
-f 291
-f 292
-f 293
-f 294
-f 295
-f 296
-f 297
-f 298
-f 299
-f 300
-f 301
-f 302
-f 303
-f 304
-f 305
-f 306
-f 307
-f 308
-f 309
-f 310
-f 311
-f 312
-f 313
-f 314
-f 315
-f 316
-f 317
-f 318
-f 319
-f 320
-f 321
-f 322
-f 323
-f 324
-f 325
-f 326
-f 327
-f 328
-f 329
-f 330
-f 331
-f 332
-f 333
-f 334
-f 335
-f 336
-f 337
-f 338
-f 339
-f 340
-f 341
-f 342
-f 343
-f 344
-f 345
-f 346
-f 347
-f 348
-f 349
-f 350
-f 351
-f 352
-f 353
-f 354
-f 355
-f 356
-f 357
-f 358
-f 359
-f 360
-f 361
-f 362
-f 363
-f 364
-f 365
-f 366
-f 367
-f 368
-f 369
-f 370
-f 371
-f 372
-f 373
-f 374
-f 375
-f 376
-f 377
-f 378
-f 379
-f 380
-f 381
-f 382
-f 383
-f 384
-f 385
-f 386
-f 387
-f 388
-f 389
-f 390
-f 391
-f 392
-f 393
-f 394
-f 395
-f 396
-f 397
-f 398
-f 399
-f 400
-f 401
-f 402
-f 403
-f 404
-f 405
-f 406
-f 407
-f 408
-f 409
-f 410
-f 411
-f 412
-f 413
-f 414
-f 415
-f 416
-f 417
-f 418
-f 419
-f 420
-f 421
-f 422
-f 423
-f 424
-f 425
-f 426
-f 427
-f 428
-f 429
-f 430
-f 431
-f 432
-f 433
-f 434
-f 435
-f 436
-f 437
-f 438
-f 439
-f 440
-f 441
-f 442
-f 443
-f 444
-f 445
-f 446
-f 447
-f 448
-f 449
-f 450
-f 451
-f 452
-f 453
-f 454
-f 455
-f 456
-f 457
-f 458
-f 459
-f 460
-f 461
-f 462
-f 463
-f 464
-f 465
-f 466
-f 467
-f 468
-f 469
-f 470
-f 471
-f 472
-f 473
-f 474
-f 475
-f 476
-f 477
-f 478
-f 479
-f 480
-f 481
-f 482
-f 483
-f 484
-f 485
-f 486
-f 487
-f 488
-f 489
-f 490
-f 491
-f 492
-f 493
-f 494
-f 495
-f 496
-f 497
-f 498
-f 499
-f 500
-f 501
-f 502
-f 503
-f 504
-f 505
-f 506
-f 507
-f 508
-f 509
-f 510
-f 511
-f 512
-f 513
-f 514
-f 515
-f 516
-f 517
-f 518
-f 519
-f 520
-f 521
-f 522
-f 523
-f 524
-f 525
-f 526
-f 527
-f 528
-f 529
-f 530
-f 531
-f 532
-f 533
-f 534
-f 535
-f 536
-f 537
-f 538
-f 539
-f 540
-f 541
-f 542
-f 543
-f 544
-f 545
-f 546
-f 547
-f 548
-f 549
-f 550
-f 551
-f 552
-f 553
-f 554
-f 555
-f 556
-f 557
-f 558
-f 559
-f 560
-f 561
-f 562
-f 563
-f 564
-f 565
-f 566
-f 567
-f 568
-f 569
-f 570
-f 571
-f 572
-f 573
-f 574
-f 575
-f 576
-f 577
-f 578
-f 579
-f 580
-f 581
-f 582
-f 583
-f 584
-f 585
-f 586
-f 587
-f 588
-f 589
-f 590
-f 591
-f 592
-f 593
-f 594
-f 595
-f 596
-f 597
-f 598
-f 599
-f 600
-f 601
-f 602
-f 603
-f 604
-f 605
-f 606
-f 607
-f 608
-f 609
-f 610
-f 611
-f 612
-f 613
-f 614
-f 615
-f 616
-f 617
-f 618
-f 619
-f 620
-f 621
-f 622
-f 623
-f 624
-f 625
-f 626
-f 627
-f 628
-f 629
-f 630
-f 631
-f 632
-f 633
-f 634
-f 635
-f 636
-f 637
-f 638
-f 639
-f 640
-f 641
-f 642
-f 643
-f 644
-f 645
-f 646
-f 647
-f 648
-f 649
-f 650
-f 651
-f 652
-f 653
-f 654
-f 655
-f 656
-f 657
-f 658
-f 659
-f 660
-f 661
-f 662
-f 663
-f 664
-f 665
-f 666
-f 667
-f 668
-f 669
-f 670
-f 671
-f 672
-f 673
-f 674
-f 675
-f 676
-f 677
-f 678
-f 679
-f 680
-f 681
-f 682
-f 683
-f 684
-f 685
-f 686
-f 687
-f 688
-f 689
-f 690
-f 691
-f 692
-f 693
-f 694
-f 695
-f 696
-f 697
-f 698
-f 699
-f 700
-f 701
-f 702
-f 703
-f 704
-f 705
-f 706
-f 707
-f 708
-f 709
-f 710
-f 711
-f 712
-f 713
-f 714
-f 715
-f 716
-f 717
-f 718
-f 719
-f 720
-f 721
-f 722
-f 723
-f 724
-f 725
-f 726
-f 727
-f 728
-f 729
-f 730
-f 731
-f 732
-f 733
-f 734
-f 735
-f 736
-f 737
-f 738
-f 739
-f 740
-f 741
-f 742
-f 743
-f 744
-f 745
-f 746
-f 747
-f 748
-f 749
-f 750
-f 751
-f 752
-f 753
-f 754
-f 755
-f 756
-f 757
-f 758
-f 759
-f 760
-f 761
-f 762
-f 763
-f 764
-f 765
-f 766
-f 767
-f 768
-f 769
-f 770
-f 771
-f 772
-f 773
-f 774
-f 775
-f 776
-f 777
-f 778
-f 779
-f 780
-f 781
-f 782
-f 783
-f 784
-f 785
-f 786
-f 787
-f 788
-f 789
-f 790
-f 791
-f 792
-f 793
-f 794
-f 795
-f 796
-f 797
-f 798
-f 799
-f 800
-f 801
-f 802
-f 803
-f 804
-f 805
-f 806
-f 807
-f 808
-f 809
-f 810
-f 811
-f 812
-f 813
-f 814
-f 815
-f 816
-f 817
-f 818
-f 819
-f 820
-f 821
-f 822
-f 823
-f 824
-f 825
-f 826
-f 827
-f 828
-f 829
-f 830
-f 831
-f 832
-f 833
-f 834
-f 835
-f 836
-f 837
-f 838
-f 839
-f 840
-f 841
-f 842
-f 843
-f 844
-f 845
-f 846
-f 847
-f 848
-f 849
-f 850
-f 851
-f 852
-f 853
-f 854
-f 855
-f 856
-f 857
-f 858
-f 859
-f 860
-f 861
-f 862
-f 863
-f 864
-f 865
-f 866
-f 867
-f 868
-f 869
-f 870
-f 871
-f 872
-f 873
-f 874
-f 875
-f 876
-f 877
-f 878
-f 879
-f 880
-f 881
-f 882
-f 883
-f 884
-f 885
-f 886
-f 887
-f 888
-f 889
-f 890
-f 891
-f 892
-f 893
-f 894
-f 895
-f 896
-f 897
-f 898
-f 899
-f 900
-f 901
-f 902
-f 903
-f 904
-f 905
-f 906
-f 907
-f 908
-f 909
-f 910
-f 911
-f 912
-f 913
-f 914
-f 915
-f 916
-f 917
-f 918
-f 919
-f 920
-f 921
-f 922
-f 923
-f 924
-f 925
-f 926
-f 927
-f 928
-f 929
-f 930
-f 931
-f 932
-f 933
-f 934
-f 935
-f 936
-f 937
-f 938
-f 939
-f 940
-f 941
-f 942
-f 943
-f 944
-f 945
-f 946
-f 947
-f 948
-f 949
-f 950
-f 951
-f 952
-f 953
-f 954
-f 955
-f 956
-f 957
-f 958
-f 959
-f 960
-f 961
-f 962
-f 963
-f 964
-f 965
-f 966
-f 967
-f 968
-f 969
-f 970
-f 971
-f 972
-f 973
-f 974
-f 975
-f 976
-f 977
-f 978
-f 979
-f 980
-f 981
-f 982
-f 983
-f 984
-f 985
-f 986
-f 987
-f 988
-f 989
-f 990
-f 991
-f 992
-f 993
-f 994
-f 995
-f 996
-f 997
-f 998
-f 999
-f 1000
+f 1
\ No newline at end of file
>From b4c15dfd9f9ed4f610f9e053a7d8dca0d69861b2 Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Wed, 19 Mar 2025 22:16:38 +0000
Subject: [PATCH 4/9] folded logic
---
lld/ELF/SyntheticSections.cpp | 11 ++++++++---
lld/ELF/SyntheticSections.h | 4 +++-
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index a97203a7ae79a..eccb99e11e3dc 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -674,10 +674,15 @@ void GotSection::addEntry(const Symbol &sym) {
// We add only a single GOT entry for all such symbols.
auto [it, inserted] = gotEntries.insert(
std::make_pair(std::make_pair(d->section, d->value),
- numEntries));
+ std::make_pair(numEntries, d->folded)));
if (!inserted) {
- ctx.symAux.back().gotIdx = it->getSecond();
- return;
+ bool prevFolded = it->getSecond().second;
+ if (!d->folded)
+ it->getSecond().second = d->folded;
+ if (d->folded || prevFolded) {
+ ctx.symAux.back().gotIdx = it->getSecond().first;
+ return;
+ }
}
}
diff --git a/lld/ELF/SyntheticSections.h b/lld/ELF/SyntheticSections.h
index 3debb08e4dd2b..bfd44d33e04ab 100644
--- a/lld/ELF/SyntheticSections.h
+++ b/lld/ELF/SyntheticSections.h
@@ -140,7 +140,9 @@ class GotSection final : public SyntheticSection {
SmallVector<AuthEntryInfo, 0> authEntries;
// To track GOT entries for symbols that may have been ICFed
- llvm::DenseMap<std::pair<SectionBase*, uint64_t>, uint32_t> gotEntries;
+ // Key is {section pointer, offset of symbol within that section}.
+ // Value is {GotIndex, whether canonical section has been encountered}
+ llvm::DenseMap<std::pair<SectionBase*, uint64_t>, std::pair<uint32_t, bool>> gotEntries;
};
// .note.GNU-stack section.
>From b41cbf58efc6c3ab3ccd59c5b81e30798dfd403a Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Wed, 19 Mar 2025 22:16:44 +0000
Subject: [PATCH 5/9] Revert "folded logic"
This reverts commit b4c15dfd9f9ed4f610f9e053a7d8dca0d69861b2.
---
lld/ELF/SyntheticSections.cpp | 11 +++--------
lld/ELF/SyntheticSections.h | 4 +---
2 files changed, 4 insertions(+), 11 deletions(-)
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index eccb99e11e3dc..a97203a7ae79a 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -674,15 +674,10 @@ void GotSection::addEntry(const Symbol &sym) {
// We add only a single GOT entry for all such symbols.
auto [it, inserted] = gotEntries.insert(
std::make_pair(std::make_pair(d->section, d->value),
- std::make_pair(numEntries, d->folded)));
+ numEntries));
if (!inserted) {
- bool prevFolded = it->getSecond().second;
- if (!d->folded)
- it->getSecond().second = d->folded;
- if (d->folded || prevFolded) {
- ctx.symAux.back().gotIdx = it->getSecond().first;
- return;
- }
+ ctx.symAux.back().gotIdx = it->getSecond();
+ return;
}
}
diff --git a/lld/ELF/SyntheticSections.h b/lld/ELF/SyntheticSections.h
index bfd44d33e04ab..3debb08e4dd2b 100644
--- a/lld/ELF/SyntheticSections.h
+++ b/lld/ELF/SyntheticSections.h
@@ -140,9 +140,7 @@ class GotSection final : public SyntheticSection {
SmallVector<AuthEntryInfo, 0> authEntries;
// To track GOT entries for symbols that may have been ICFed
- // Key is {section pointer, offset of symbol within that section}.
- // Value is {GotIndex, whether canonical section has been encountered}
- llvm::DenseMap<std::pair<SectionBase*, uint64_t>, std::pair<uint32_t, bool>> gotEntries;
+ llvm::DenseMap<std::pair<SectionBase*, uint64_t>, uint32_t> gotEntries;
};
// .note.GNU-stack section.
>From d63758d1e6c1c105a7cdd2543ff8329a240617b8 Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Wed, 19 Mar 2025 23:57:30 +0000
Subject: [PATCH 6/9] test for preemptible & check sym types when adding
gotEntries
---
lld/ELF/Relocations.cpp | 3 +--
lld/ELF/SyntheticSections.cpp | 24 +++++++++++--------
lld/ELF/SyntheticSections.h | 6 ++---
...rp-ldr-icf.s => aarch64-got-merging-icf.s} | 20 ++++++++++++----
4 files changed, 33 insertions(+), 20 deletions(-)
rename lld/test/ELF/{aarch64-adrp-ldr-icf.s => aarch64-got-merging-icf.s} (54%)
diff --git a/lld/ELF/Relocations.cpp b/lld/ELF/Relocations.cpp
index 629702b45965b..99fd91b5f2d1f 100644
--- a/lld/ELF/Relocations.cpp
+++ b/lld/ELF/Relocations.cpp
@@ -915,8 +915,7 @@ void elf::addGotEntry(Ctx &ctx, Symbol &sym) {
}
static void addGotAuthEntry(Ctx &ctx, Symbol &sym) {
- ctx.in.got->addEntry(sym);
- ctx.in.got->addAuthEntry(sym);
+ ctx.in.got->addEntry(sym, /*authEntry = */ true);
uint64_t off = sym.getGotOffset(ctx);
// If preemptible, emit a GLOB_DAT relocation.
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index a97203a7ae79a..bd57a52a82d9a 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -665,27 +665,31 @@ GotSection::GotSection(Ctx &ctx)
}
void GotSection::addConstant(const Relocation &r) { relocations.push_back(r); }
-void GotSection::addEntry(const Symbol &sym) {
+void GotSection::addEntry(const Symbol &sym, bool authEntry) {
assert(sym.auxIdx == ctx.symAux.size() - 1);
auto *d = dyn_cast<Defined>(&sym);
+ std::optional<uint32_t> finalGotIdx;
if (d && !d->isPreemptible && ctx.arg.icf != ICFLevel::None) {
// There may be symbols that have been ICFed in which case d->section
// points to their canonical section and d->value is offset in to that section.
// We add only a single GOT entry for all such symbols.
- auto [it, inserted] = gotEntries.insert(
- std::make_pair(std::make_pair(d->section, d->value),
- numEntries));
+ auto [it, inserted] = gotEntries.insert(std::make_pair(
+ std::make_tuple(d->section, d->value, sym.type), numEntries));
if (!inserted) {
- ctx.symAux.back().gotIdx = it->getSecond();
- return;
+ finalGotIdx = it->getSecond();
}
}
- ctx.symAux.back().gotIdx = numEntries++;
-}
+ if (!finalGotIdx.has_value()) {
+ finalGotIdx = numEntries++;
+ }
+
+ if (authEntry) {
+ authEntries.push_back(
+ {finalGotIdx.value() * ctx.arg.wordsize, sym.isFunc()});
+ }
-void GotSection::addAuthEntry(const Symbol &sym) {
- authEntries.push_back({(numEntries - 1) * ctx.arg.wordsize, sym.isFunc()});
+ ctx.symAux.back().gotIdx = finalGotIdx.value();
}
bool GotSection::addTlsDescEntry(const Symbol &sym) {
diff --git a/lld/ELF/SyntheticSections.h b/lld/ELF/SyntheticSections.h
index 3debb08e4dd2b..a421b1b551103 100644
--- a/lld/ELF/SyntheticSections.h
+++ b/lld/ELF/SyntheticSections.h
@@ -111,8 +111,7 @@ class GotSection final : public SyntheticSection {
void writeTo(uint8_t *buf) override;
void addConstant(const Relocation &r);
- void addEntry(const Symbol &sym);
- void addAuthEntry(const Symbol &sym);
+ void addEntry(const Symbol &sym, bool authEntry = false);
bool addTlsDescEntry(const Symbol &sym);
void addTlsDescAuthEntry();
bool addDynTlsEntry(const Symbol &sym);
@@ -140,7 +139,8 @@ class GotSection final : public SyntheticSection {
SmallVector<AuthEntryInfo, 0> authEntries;
// To track GOT entries for symbols that may have been ICFed
- llvm::DenseMap<std::pair<SectionBase*, uint64_t>, uint32_t> gotEntries;
+ llvm::DenseMap<std::tuple<SectionBase *, uint64_t, unsigned char>, uint32_t>
+ gotEntries;
};
// .note.GNU-stack section.
diff --git a/lld/test/ELF/aarch64-adrp-ldr-icf.s b/lld/test/ELF/aarch64-got-merging-icf.s
similarity index 54%
rename from lld/test/ELF/aarch64-adrp-ldr-icf.s
rename to lld/test/ELF/aarch64-got-merging-icf.s
index f6dd47f204148..9f359cbf3a0a9 100644
--- a/lld/test/ELF/aarch64-adrp-ldr-icf.s
+++ b/lld/test/ELF/aarch64-got-merging-icf.s
@@ -1,10 +1,17 @@
// REQUIRES: aarch64
-// RUN: llvm-mc -filetype=obj -triple=aarch64 %s -o %t
-// RUN: ld.lld %t -o %t2 --icf=all
-// RUN: llvm-objdump --section-headers %t2 | FileCheck %s
+# RUN: llvm-mc -filetype=obj -triple=aarch64 %s -o %t
+# RUN: ld.lld %t -o %t2 --icf=all
+# RUN: llvm-objdump --section-headers %t2 | FileCheck %s --check-prefix=EXE
-// CHECK: {{.*}}.got 00000008{{.*}}
+# RUN: ld.lld -shared %t -o %t3 --icf=all
+# RUN: llvm-objdump --section-headers %t3 | FileCheck %s --check-prefix=DSO
+
+## All .rodata.* sections should merge into a single GOT entry
+# EXE: {{.*}}.got 00000008{{.*}}
+
+## When symbols are preemptible in DSO mode, GOT entries wouldn't be merged
+# DSO: {{.*}}.got 00000020{{.*}}
.addrsig
@@ -37,6 +44,7 @@ f2_\index:
ldr x0, [x0, :got_lo12:g\index]
b callee
+.globl g\index
.section .rodata.g\index,"a", at progbits
g_\index:
.long 111
@@ -55,4 +63,6 @@ bl f1_\index
_start:
f 0
-f 1
\ No newline at end of file
+f 1
+f 2
+f 3
>From c362247dde5922e7de13c06dde2e6782282aae37 Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Thu, 20 Mar 2025 00:23:20 +0000
Subject: [PATCH 7/9] formatting
---
lld/ELF/SyntheticSections.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index bd57a52a82d9a..2555d09264ecb 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -671,8 +671,8 @@ void GotSection::addEntry(const Symbol &sym, bool authEntry) {
std::optional<uint32_t> finalGotIdx;
if (d && !d->isPreemptible && ctx.arg.icf != ICFLevel::None) {
// There may be symbols that have been ICFed in which case d->section
- // points to their canonical section and d->value is offset in to that section.
- // We add only a single GOT entry for all such symbols.
+ // points to their canonical section and d->value is offset in to that
+ // section. We add only a single GOT entry for all such symbols.
auto [it, inserted] = gotEntries.insert(std::make_pair(
std::make_tuple(d->section, d->value, sym.type), numEntries));
if (!inserted) {
>From c667ee7cacbf96d149a620dd90f1119256775c50 Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Mon, 24 Mar 2025 23:41:46 +0000
Subject: [PATCH 8/9] address review comments
---
lld/ELF/ICF.cpp | 13 ++++---------
lld/ELF/Symbols.h | 2 ++
lld/ELF/SyntheticSections.cpp | 8 ++++----
3 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/lld/ELF/ICF.cpp b/lld/ELF/ICF.cpp
index 1cdcf6be9d8a9..43defed1418c2 100644
--- a/lld/ELF/ICF.cpp
+++ b/lld/ELF/ICF.cpp
@@ -262,15 +262,10 @@ bool ICF<ELFT>::constantEq(const InputSection *secA, Relocs<RelTy> ra,
auto *db = dyn_cast<Defined>(&sb);
// Placeholder symbols generated by linker scripts look the same now but
- // may have different values later.
- if (!da || !db || da->scriptDefined || db->scriptDefined)
- return false;
-
- // When comparing a pair of relocations, if they refer to different symbols,
- // and either symbol is preemptible, the containing sections should be
- // considered different. This is because even if the sections are identical
- // in this DSO, they may not be after preemption.
- if (da->isPreemptible || db->isPreemptible)
+ // may have different values later. Similarly, preemptible symbols may be
+ // different after preemption. When comparing a pair of relocation, if they
+ // refer to different symbols, containing sections should be treated different.
+ if (!da || !db || !da->isFoldable() || !db->isFoldable())
return false;
// Relocations referring to absolute symbols are constant-equal if their
diff --git a/lld/ELF/Symbols.h b/lld/ELF/Symbols.h
index 64f2f6eaa8d09..775e881cb129f 100644
--- a/lld/ELF/Symbols.h
+++ b/lld/ELF/Symbols.h
@@ -156,6 +156,8 @@ class Symbol {
}
uint8_t computeBinding(Ctx &) const;
+ // Preemptible and script defined symbols cannot ever be treated same
+ bool isFoldable() const { return !isPreemptible && !scriptDefined; }
bool isGlobal() const { return binding == llvm::ELF::STB_GLOBAL; }
bool isWeak() const { return binding == llvm::ELF::STB_WEAK; }
diff --git a/lld/ELF/SyntheticSections.cpp b/lld/ELF/SyntheticSections.cpp
index 2555d09264ecb..18eb77e2e3551 100644
--- a/lld/ELF/SyntheticSections.cpp
+++ b/lld/ELF/SyntheticSections.cpp
@@ -669,10 +669,10 @@ void GotSection::addEntry(const Symbol &sym, bool authEntry) {
assert(sym.auxIdx == ctx.symAux.size() - 1);
auto *d = dyn_cast<Defined>(&sym);
std::optional<uint32_t> finalGotIdx;
- if (d && !d->isPreemptible && ctx.arg.icf != ICFLevel::None) {
- // There may be symbols that have been ICFed in which case d->section
- // points to their canonical section and d->value is offset in to that
- // section. We add only a single GOT entry for all such symbols.
+ if (d && d->isFoldable()) {
+ // Generate one GOT entry for all foldable symbols. This could be due to
+ // ICF where containing sections have now been folded into one, or aliases
+ // that all point to the same symbol.
auto [it, inserted] = gotEntries.insert(std::make_pair(
std::make_tuple(d->section, d->value, sym.type), numEntries));
if (!inserted) {
>From 8b11790e0b00feab24643c7ee5bc8dcffb2b6d02 Mon Sep 17 00:00:00 2001
From: Pranav Kant <pranav913 at gmail.com>
Date: Wed, 26 Mar 2025 15:22:02 -0700
Subject: [PATCH 9/9] review: Update lld/ELF/ICF.cpp
Co-authored-by: Reid Kleckner <rnk at google.com>
---
lld/ELF/ICF.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lld/ELF/ICF.cpp b/lld/ELF/ICF.cpp
index 43defed1418c2..5031795086c85 100644
--- a/lld/ELF/ICF.cpp
+++ b/lld/ELF/ICF.cpp
@@ -263,8 +263,8 @@ bool ICF<ELFT>::constantEq(const InputSection *secA, Relocs<RelTy> ra,
// Placeholder symbols generated by linker scripts look the same now but
// may have different values later. Similarly, preemptible symbols may be
- // different after preemption. When comparing a pair of relocation, if they
- // refer to different symbols, containing sections should be treated different.
+ // different after preemption. When comparing a pair of relocations, if they
+ // refer to different symbols, the containing sections should be considered different.
if (!da || !db || !da->isFoldable() || !db->isFoldable())
return false;
More information about the llvm-commits
mailing list