[compiler-rt] [ctxprof] Auto root detection: trie for stack samples (PR #133106)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff e04d739522f9df450c88bb1ec17cbd39c0babf8f aa29e5a0c3b6ae461f32048d557b31a42ac179a2 --extensions h,cpp -- compiler-rt/lib/ctx_profile/RootAutoDetector.cpp compiler-rt/lib/ctx_profile/RootAutoDetector.h compiler-rt/lib/ctx_profile/tests/RootAutoDetectorTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/compiler-rt/lib/ctx_profile/RootAutoDetector.cpp b/compiler-rt/lib/ctx_profile/RootAutoDetector.cpp
index e1d9958270..7daa8f31e1 100644
--- a/compiler-rt/lib/ctx_profile/RootAutoDetector.cpp
+++ b/compiler-rt/lib/ctx_profile/RootAutoDetector.cpp
@@ -13,8 +13,8 @@
 #include "sanitizer_common/sanitizer_mutex.h"
 #include "sanitizer_common/sanitizer_placement_new.h"
 #include <assert.h>
-#include <pthread.h>
 #include <dlfcn.h>
+#include <pthread.h>
 
 using namespace __ctx_profile;
 
@@ -70,11 +70,11 @@ DenseMap<uptr, uint64_t> PerThreadCallsiteTrie::determineRoots() const {
   while (!Worklist.empty()) {
     Set<const Trie *> NextWorklist;
     DenseMap<uptr, uint64_t> Candidates;
-    Worklist.forEach([&](auto &KVP){
+    Worklist.forEach([&](auto &KVP) {
       auto [Node, _] = KVP;
       auto SA = getFctStartAddr(Node->CallsiteAddress);
       Candidates[SA] += Node->Count;
-      Node->Children.forEach([&](auto &ChildKVP){
+      Node->Children.forEach([&](auto &ChildKVP) {
         NextWorklist.insert({&ChildKVP.second, {}});
         return true;
       });
diff --git a/compiler-rt/lib/ctx_profile/RootAutoDetector.h b/compiler-rt/lib/ctx_profile/RootAutoDetector.h
index 1aae60cafa..ab51a342d3 100644
--- a/compiler-rt/lib/ctx_profile/RootAutoDetector.h
+++ b/compiler-rt/lib/ctx_profile/RootAutoDetector.h
@@ -20,8 +20,7 @@ using namespace __sanitizer;
 
 namespace __ctx_profile {
 
-template<typename T>
-using Set = DenseMap<T, bool>;
+template <typename T> using Set = DenseMap<T, bool>;
 
 /// A trie. A node is the address of a callsite in a function activation. A
 /// child is a callsite in the activation made from the callsite corresponding
@@ -57,7 +56,7 @@ public:
 
   virtual ~PerThreadCallsiteTrie() = default;
 
-  void insertStack(const StackTrace& ST);
+  void insertStack(const StackTrace &ST);
 
   /// Return the runtime address of root functions, as determined for this
   /// thread, together with the number of samples that included them.
diff --git a/compiler-rt/lib/ctx_profile/tests/RootAutoDetectorTest.cpp b/compiler-rt/lib/ctx_profile/tests/RootAutoDetectorTest.cpp
index 34f110871b..3e955d33e9 100644
--- a/compiler-rt/lib/ctx_profile/tests/RootAutoDetectorTest.cpp
+++ b/compiler-rt/lib/ctx_profile/tests/RootAutoDetectorTest.cpp
@@ -12,7 +12,7 @@ class MockCallsiteTree final : public PerThreadCallsiteTrie {
 };
 
 class Marker {
-  enum class Kind { End, Value, Split};
+  enum class Kind { End, Value, Split };
   const uptr Value;
   const Kind K;
   Marker(uptr V, Kind S) : Value(V), K(S) {}
@@ -24,7 +24,7 @@ public:
   static Marker term() { return Marker(0, Kind::End); }
 
   bool isSplit() const { return K == Kind::Split; }
-  bool isTerm() const { return K == Kind::End;}
+  bool isTerm() const { return K == Kind::End; }
   bool isVal() const { return K == Kind::Value; }
 
   bool operator==(const Marker &M) const {
@@ -40,7 +40,7 @@ void popAndCheck(ArrayRef<Marker> &Preorder, Marker M) {
 
 void checkSameImpl(const Trie &T, ArrayRef<Marker> &Preorder) {
   popAndCheck(Preorder, T.address());
-  
+
   if (T.children().size() == 0) {
     popAndCheck(Preorder, Marker::term());
     return;

``````````

</details>


https://github.com/llvm/llvm-project/pull/133106