[clang] [llvm] [clang][CodeGen] Generate follow-up metadata for loops in correct format (PR #131985)

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 26 07:58:39 PDT 2025


================
@@ -44,23 +44,19 @@ MDNode *LoopInfo::createPipeliningMetadata(const LoopAttributes &Attrs,
   else if (Attrs.PipelineInitiationInterval != 0)
     Enabled = true;
 
+  SmallVector<Metadata *, 4> Args;
+  Args.append(LoopProperties.begin(), LoopProperties.end());
+
   if (Enabled != true) {
-    SmallVector<Metadata *, 4> NewLoopProperties;
     if (Enabled == false) {
-      NewLoopProperties.append(LoopProperties.begin(), LoopProperties.end());
----------------
Meinersbur wrote:

This line was not executed when `Enabled == std::nullop`, so `llvm.mustprogress` (`[[MP]]`) from `LoopProperties` is never added. Should have been added unconditionally.

https://github.com/llvm/llvm-project/pull/131985


More information about the llvm-commits mailing list