[llvm] [GlobalOpt] Handle operators separately when removing GV users (PR #84694)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 25 11:31:53 PDT 2025


efriedma-quic wrote:

If you patch isn't getting appropriate review, merging it is not an appropriate way to escalate.  Appropriate ways include privately emailing reviewers, or starting a thread on Discourse.

-----

I apologize for not continuing to review this in a timely fashion.  I should not have ignored the patch like this, after I started reviewing.

There are basically two ways forward for this patch: one, you preserve the "leak root" check so that allocation checking tools don't break.  Two, we explicitly decide to break any tools that depend on "leak root" checking (probably needs an RFC).  Your patch is currently doing neither one of those; it's still trying to straddle the middle in a way I can't understand.

https://github.com/llvm/llvm-project/pull/84694


More information about the llvm-commits mailing list