[llvm] [llvm][ADT] Some AddressRanges.h improvements (PR #132847)

[David Blaikie via llvm-commits]

================
@@ -22,14 +22,16 @@ namespace llvm {
 class AddressRange {
 public:
   AddressRange() {}
-  AddressRange(uint64_t S, uint64_t E) : Start(S), End(E) {
+  AddressRange(const uint64_t S, const uint64_t E) : Start(S), End(E) {
----------------
dwblaikie wrote:

FWIW, unless we moved to /always/ use const on top level types across the codebase (or perhaps even within a part of it - though I'm fairly averse to local styles) I find it harmful to readability to only put const on some top level types - mostly it makes me wonder what's special about the handful of places it does get used (even within this patch it's not applied uniformly - or there's some rule/rubrick I can't determine) and wonder whether the author intended "const&" and missed the "&" somewhere along the way.

https://github.com/llvm/llvm-project/pull/132847