[llvm] [IR][JumpThreading] Fix infinite recursion on compare self-reference [updated] (PR #129501)

[Michael Kruse via llvm-commits]

https://github.com/Meinersbur commented:

I overlooked the responses after https://github.com/llvm/llvm-project/pull/129501#issuecomment-2748329091. So yes, de6ae293645a90bf76d7a0c74ffff6b76b2d9729 addresses my concern. The PHI was an example, I did not look into what `evaluateOnPredecessorEdge` recurses over.

I would prefer if the `insert` and `erase` would be done in the same call. A final review by @nikic would be good.

https://github.com/llvm/llvm-project/pull/129501