[llvm] [AMDGPU] Remove the AnnotateKernelFeatures pass (PR #130198)

[Jun Wang via llvm-commits]

================
@@ -0,0 +1,550 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 < %s | FileCheck -check-prefixes=GFX9 %s
+; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx1010 < %s | FileCheck -check-prefixes=GFX10 %s
+
+;
+; These functions all should have the attribute amdgpu-no-flat-scratch-init set if the AMDGPUAttributor
+; pass is run. Therefore the purpose is to test llc when the attribute is incorrectly missing.
----------------
jwanggit86 wrote:

> This test is not running the attributor, only codegen. This is also the opposite of the test I wanted. I wanted to test the case where the functions do have the attribute, but violate the contract. That is, every function should already have the attribute set. And then use the casts and flat accesses which would require flat_scr to be initialized

Now I have two files, one to run opt (attributor-flatscratchinit-invalid.ll) and one to run llc (attributor-flatscratchinit-invalid2.ll). One question about opt. If a function is not supposed to have the attribute but somehow has it, should attributor remove it? 

https://github.com/llvm/llvm-project/pull/130198