[llvm] [AMDGPU] Remove the AnnotateKernelFeatures pass (PR #130198)
Jun Wang via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 24 11:21:01 PDT 2025
jwanggit86 wrote:
> > Most of the test changes should just regenerate to use the new output, and not add the attribute. The attribute should only be added in cases where it's directly relevant to the test (like the kernel metadata tests)
>
> I'm not sure. Adding the attribute to existing test cases can avoid unnecessary check line changes, which makes the line history more consistent.
I'm fine either way, but now most of the manually added attributes have been removed.
https://github.com/llvm/llvm-project/pull/130198
More information about the llvm-commits
mailing list