[llvm] [SystemZ, DebugInfo] Support InstrRef-based Debug Value Tracking in the SystemZ backend (PR #132415)
Ulrich Weigand via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 24 11:19:10 PDT 2025
uweigand wrote:
> > I understand, but i do think both of the points you raise are strictly related.
>
> I guess they are needed to have for your patch, but what I meant is that if they could be pre-committed as separate items that would make this one easier to review. Alternatively, keep them here, but then make sure you commit those things as separate commits.
Hi @dominik-steenken , just to clarify: while you've separated the changes into different commits, that doesn't really help when committing via GitHub - the interface will always squash all commits into a single one. So to actually commit things in multiple parts, you'd have to open multiple different PRs in the first place - and I think this would be a good idea, in particular for the preparation stuff. So maybe one PR for isCopyInstrImpl, one for is..StackSlotPostFE, one for the pass-initialization fix, and then one for actually updating all the passes.
https://github.com/llvm/llvm-project/pull/132415
More information about the llvm-commits
mailing list