[llvm] f0bc171 - [Mips] Simplify evaluateAsRelocatableImpl and avoid getSymB calls

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2025-03-24T09:38:42-07:00
New Revision: f0bc1712a3e35c0a4c967b88f62ff8e216c002c9

URL: https://github.com/llvm/llvm-project/commit/f0bc1712a3e35c0a4c967b88f62ff8e216c002c9
DIFF: https://github.com/llvm/llvm-project/commit/f0bc1712a3e35c0a4c967b88f62ff8e216c002c9.diff

LOG: [Mips] Simplify evaluateAsRelocatableImpl and avoid getSymB calls

The MCValue::SymB MCSymbolRefExpr member might be replaced with a
MCSymbol in the future. Reduce direct access.

Added: 
    

Modified: 
    llvm/lib/Target/Mips/MCTargetDesc/MipsMCExpr.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/Mips/MCTargetDesc/MipsMCExpr.cpp b/llvm/lib/Target/Mips/MCTargetDesc/MipsMCExpr.cpp
index 03c675e08185e..d5eca7b65b2b1 100644
--- a/llvm/lib/Target/Mips/MCTargetDesc/MipsMCExpr.cpp
+++ b/llvm/lib/Target/Mips/MCTargetDesc/MipsMCExpr.cpp
@@ -140,16 +140,14 @@ bool MipsMCExpr::evaluateAsRelocatableImpl(MCValue &Res,
     if (!SubExpr->evaluateAsRelocatable(Res, Asm))
       return false;
 
-    Res = MCValue::get(Res.getSymA(), Res.getSymB(), Res.getConstant(),
-                       MEK_Special);
+    Res.setSpecifier(MEK_Special);
     return true;
   }
 
   if (!getSubExpr()->evaluateAsRelocatable(Res, Asm))
     return false;
-  Res = MCValue::get(Res.getSymA(), Res.getSymB(), Res.getConstant(),
-                     getSpecifier());
-  return !Res.getSymB();
+  Res.setSpecifier(specifier);
+  return !Res.getSubSym();
 }
 
 void MipsMCExpr::visitUsedExpr(MCStreamer &Streamer) const {