[llvm] GCStrategy: Use Twine properly for error message (PR #132760)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-ir

Author: Matt Arsenault (arsenm)

<details>
<summary>Changes</summary>

Avoid unnecessary std::string temporaries.

---
Full diff: https://github.com/llvm/llvm-project/pull/132760.diff


1 Files Affected:

- (modified) llvm/lib/IR/GCStrategy.cpp (+4-5) 


``````````diff
diff --git a/llvm/lib/IR/GCStrategy.cpp b/llvm/lib/IR/GCStrategy.cpp
index c3e35bd58d13e..67f363d26b25f 100644
--- a/llvm/lib/IR/GCStrategy.cpp
+++ b/llvm/lib/IR/GCStrategy.cpp
@@ -41,10 +41,9 @@ std::unique_ptr<GCStrategy> llvm::getGCStrategy(const StringRef Name) {
     // be the builtin GCs if nothing else.  The most likely scenario here is
     // that we got here without running the initializers used by the Registry
     // itself and it's registration mechanism.
-    const std::string error =
-        std::string("unsupported GC: ") + Name.str() +
-        " (did you remember to link and initialize the library?)";
-    report_fatal_error(Twine(error));
+    report_fatal_error(
+        "unsupported GC: " + Name +
+        " (did you remember to link and initialize the library?)");
   } else
-    report_fatal_error(Twine(std::string("unsupported GC: ") + Name.str()));
+    report_fatal_error(Twine("unsupported GC: ") + Name);
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/132760