[llvm] [BOLT] Support computed goto and allow map addrs inside functions (PR #120267)

[Maksim Panchenko via llvm-commits]

================
@@ -2439,6 +2439,33 @@ void RewriteInstance::readDynamicRelocations(const SectionRef &Section,
     if (Symbol)
       SymbolIndex[Symbol] = getRelocationSymbol(InputFile, Rel);
 
+    const uint64_t ReferencedAddress = SymbolAddress + Addend;
+    BinaryFunction *Func =
+        BC->getBinaryFunctionContainingAddress(ReferencedAddress);
+
+    if (Relocation::isRelative(RType) && SymbolAddress == 0) {
+      if (Func) {
+        if (!Func->isInConstantIsland(ReferencedAddress)) {
+          if (const uint64_t ReferenceOffset =
+                  ReferencedAddress - Func->getAddress()) {
+            Func->addEntryPointAtOffset(ReferenceOffset);
+          } else if (ReferencedAddress < Func->getAddress()) {
----------------
maksfb wrote:

Since `Func` is discovered using `getBinaryFunctionContainingAddress(ReferencedAddress)`, we should never hit this condition. You can use `ReferencedOffset` unconditionally.

https://github.com/llvm/llvm-project/pull/120267