[lld] [lld-macho] Improve ICF thunk folding logic (PR #131186)

[Peter Rong via llvm-commits]

================
@@ -297,16 +297,25 @@ static Symbol *getThunkTargetSymbol(ConcatInputSection *isec) {
 // direct branch thunk rather than containing a full copy of the actual function
 // body.
 void ICF::applySafeThunksToRange(size_t begin, size_t end) {
+  // When creating a unique ICF thunk, use the first section as the section that
+  // all thunks will branch to.
+  ConcatInputSection *masterIsec = icfInputs[begin];
+
+  // If the first section is not address significant, sorting guarantees that
+  // there are no address significant functions. So we can skip this range.
+  if (!masterIsec->keepUnique)
+    return;
+
+  // Skip anything that is not a code section.
+  if (!isCodeSection(masterIsec))
----------------
DataCorrupted wrote:

Does sorting also guarantees that all code section will be in the front? I vaguely remember this is the case but can't confirm.

https://github.com/llvm/llvm-project/pull/131186