[llvm] [ci] Add ids workflow for checking llvm apis have been annotated with LLVM_ABI (PR #128370)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 14 01:08:56 PDT 2025
https://github.com/mcbarton updated https://github.com/llvm/llvm-project/pull/128370
>From ea8b869fe13e67e7d12573d9e425bd3ee00945f4 Mon Sep 17 00:00:00 2001
From: mcbarton <150042563+mcbarton at users.noreply.github.com>
Date: Tue, 7 Jan 2025 09:06:17 +0000
Subject: [PATCH 1/4] Add ids workflow
---
.github/workflows/ids-check.yml | 77 +++++++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
create mode 100644 .github/workflows/ids-check.yml
diff --git a/.github/workflows/ids-check.yml b/.github/workflows/ids-check.yml
new file mode 100644
index 0000000000000..1817de03b761e
--- /dev/null
+++ b/.github/workflows/ids-check.yml
@@ -0,0 +1,77 @@
+name: ids-check
+on:
+ pull_request:
+ branches: [main]
+ push:
+ branches: [main]
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
+ cancel-in-progress: true
+
+jobs:
+ build:
+ name: ${{ matrix.name }}
+ runs-on: ${{ matrix.os }}
+ strategy:
+ fail-fast: false
+ matrix:
+ include:
+ - name: ids-check
+ os: ubuntu-24.04
+
+ steps:
+ - uses: actions/checkout at v4
+ with:
+ repository: compnerd/ids
+ path: ${{ github.workspace }}/ids
+ fetch-depth: 0
+
+ - uses: actions/checkout at v4
+ with:
+ path: ${{ github.workspace }}/llvm-project
+ fetch-depth: 2
+
+ - name: install dependencies
+ run: |
+ sudo apt install -y clang-18 ninja-build libclang-18-dev
+ pip install lit
+
+ - name: Configure and build minimal LLVM for use by ids
+ run: |
+ cmake -B ${{ github.workspace }}/llvm-project/build/ \
+ -D CMAKE_BUILD_TYPE=Release \
+ -S ${{ github.workspace }}/llvm-project/llvm/ \
+ -D LLVM_ENABLE_PROJECTS=clang \
+ -D LLVM_TARGETS_TO_BUILD="host" \
+ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
+ -G Ninja
+ cd ${{ github.workspace }}/llvm-project/build/
+ ninja -t targets all | grep "CommonTableGen: phony$" | grep -v "/" | sed 's/:.*//'
+
+ - name: Configure ids
+ run: |
+ cmake -B ${{ github.workspace }}/ids/build/ \
+ -S ${{ github.workspace }}/ids/ \
+ -D CMAKE_BUILD_TYPE=Release \
+ -D CMAKE_C_COMPILER=clang \
+ -D CMAKE_CXX_COMPILER=clang++ \
+ -D CMAKE_EXE_LINKER_FLAGS=-fuse-ld=lld \
+ -D LLVM_DIR=/usr/lib/llvm-18/lib/cmake/llvm/ \
+ -D Clang_DIR=/usr/lib/llvm-18/lib/cmake/clang/ \
+ -D FILECHECK_EXECUTABLE=$(which FileCheck-18) \
+ -D LIT_EXECUTABLE=$(which lit)
+
+ - name: Build ids
+ run: |
+ cmake --build ${{ github.workspace }}/ids/build \
+ --config Release \
+ --parallel $(nproc --all)
+
+ - name: Run ids over compilation database
+ run: |
+ cd ${{ github.workspace }}/llvm-project
+ export H_OR_CPP_FILES_CHANGED_LAST_COMMIT=$(git diff --name-only HEAD~1 HEAD -- '*.cpp' '*.h')
+ if [ ! -z "${H_OR_CPP_FILES_CHANGED_LAST_COMMIT}" ]; then
+ ${{ github.workspace }}/ids/build/bin/idt -p ${{ github.workspace }}/llvm-project/build/compile_commands.json --export-macro=LLVM_ABI $(git diff --name-only HEAD~1 HEAD -- '*.cpp' '*.h')
+ fi
>From 2b5fbeeacffbaae96f1dfe223d5411f7d5e59148 Mon Sep 17 00:00:00 2001
From: mcbarton <matthew.c.barton at hotmail.co.uk>
Date: Tue, 11 Mar 2025 20:38:49 +0000
Subject: [PATCH 2/4] Apply PR suggestions
---
.github/workflows/ids-check.yml | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/.github/workflows/ids-check.yml b/.github/workflows/ids-check.yml
index 1817de03b761e..4559a0639be8b 100644
--- a/.github/workflows/ids-check.yml
+++ b/.github/workflows/ids-check.yml
@@ -5,20 +5,19 @@ on:
push:
branches: [main]
+permissions:
+ contents: read
+
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
build:
- name: ${{ matrix.name }}
- runs-on: ${{ matrix.os }}
+ name: ids-check
+ runs-on: ubuntu-24.04
strategy:
fail-fast: false
- matrix:
- include:
- - name: ids-check
- os: ubuntu-24.04
steps:
- uses: actions/checkout at v4
>From faf501715bfaa9034d051979a00a854c9b251010 Mon Sep 17 00:00:00 2001
From: mcbarton <matthew.c.barton at hotmail.co.uk>
Date: Thu, 13 Mar 2025 19:48:21 +0000
Subject: [PATCH 3/4] Apply PR suggestions
---
.github/workflows/ids-check.yml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/ids-check.yml b/.github/workflows/ids-check.yml
index 4559a0639be8b..11c119da660be 100644
--- a/.github/workflows/ids-check.yml
+++ b/.github/workflows/ids-check.yml
@@ -14,13 +14,12 @@ concurrency:
jobs:
build:
+ if: github.repository_owner == 'llvm'
name: ids-check
runs-on: ubuntu-24.04
- strategy:
- fail-fast: false
steps:
- - uses: actions/checkout at v4
+ - uses: actions/checkout at 11bd71901bbe5b1630ceea73d27597364c9af683
with:
repository: compnerd/ids
path: ${{ github.workspace }}/ids
>From 0e30999cc1bfe23678591fdb9a0052c9ce7d0099 Mon Sep 17 00:00:00 2001
From: mcbarton <matthew.c.barton at hotmail.co.uk>
Date: Fri, 14 Mar 2025 08:08:46 +0000
Subject: [PATCH 4/4] Apply PR suggestions
---
.github/workflows/ids-check.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/ids-check.yml b/.github/workflows/ids-check.yml
index 11c119da660be..56b9e275223c8 100644
--- a/.github/workflows/ids-check.yml
+++ b/.github/workflows/ids-check.yml
@@ -19,13 +19,13 @@ jobs:
runs-on: ubuntu-24.04
steps:
- - uses: actions/checkout at 11bd71901bbe5b1630ceea73d27597364c9af683
+ - uses: actions/checkout at 11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: compnerd/ids
path: ${{ github.workspace }}/ids
fetch-depth: 0
- - uses: actions/checkout at v4
+ - uses: actions/checkout at 11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
path: ${{ github.workspace }}/llvm-project
fetch-depth: 2
More information about the llvm-commits
mailing list