[llvm] [llvm-objcopy] Apply encryptable offset to first segment, not section (PR #130517)

[via llvm-commits]

Daniel =?utf-8?q?Rodríguez_Troitiño?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/130517 at github.com>


================
@@ -116,11 +116,10 @@ uint64_t MachOLayoutBuilder::layoutSegments() {
   const bool IsObjectFile =
       O.Header.FileType == MachO::HeaderFileType::MH_OBJECT;
   uint64_t Offset = IsObjectFile ? (HeaderSize + O.Header.SizeOfCmds) : 0;
-  if (O.EncryptionInfoCommandIndex) {
-    // If we are emitting an encryptable binary, our load commands must have a
-    // separate (non-encrypted) page to themselves.
-    Offset = alignToPowerOf2(HeaderSize + O.Header.SizeOfCmds, PageSize);
-  }
+  // If we are emitting an encryptable binary, our load commands must have a
+  // separate (non-encrypted) page to themselves.
+  bool FirstSectExtraEncryptableOffset =
----------------
alx32 wrote:

nit: `FirstSectExtraEncryptableOffset` sounds like `uint64_t` rather than `bool`
```suggestion
  bool RequiresPageAlignedSectionOffset =
```

https://github.com/llvm/llvm-project/pull/130517