[llvm] [llvm] DLLExport public methods from SmallVector (PR #127850)
Jakub Kuderski via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 13 09:42:04 PDT 2025
kuhar wrote:
+1 to what @nikic. The current organization of the issues and PRs doesn't make it easy to understand the larger context without significant effort, like I explained in https://github.com/llvm/llvm-project/pull/127850#issuecomment-2670322452.
> FWIW, this has already had an RFC on Discourse (https://discourse.llvm.org/t/supporting-llvm-build-llvm-dylib-on-windows/58891) as well as has a meta issue for tracking progress (#109483). I agree that it's a sweeping change, but I believe the buy-in already exists and this work has been ongoing for quite a while (at least in Clang, I'm less up-to-date on the LLVM side).
You definitely have local buy-in, but I don't believe you reached global visibility to convince unrelated parties whose code this will end up modifying. A fresh PSA discourse post would go a long way IMO.
https://github.com/llvm/llvm-project/pull/127850
More information about the llvm-commits
mailing list