[libc] [llvm] [libc][math][c23] Add fsqrtf16 C23 math functions. (PR #131153)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 13 08:07:02 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libc
Author: Harrison Hao (harrisonGPU)
<details>
<summary>Changes</summary>
Implementation of fsqrtf16 function for 16-bit inputs.
---
Full diff: https://github.com/llvm/llvm-project/pull/131153.diff
16 Files Affected:
- (modified) libc/config/gpu/amdgpu/entrypoints.txt (+1)
- (modified) libc/config/gpu/nvptx/entrypoints.txt (+1)
- (modified) libc/config/linux/aarch64/entrypoints.txt (+1)
- (modified) libc/config/linux/x86_64/entrypoints.txt (+1)
- (modified) libc/docs/headers/math/index.rst (+1-1)
- (modified) libc/include/math.yaml (+7)
- (modified) libc/src/math/CMakeLists.txt (+1)
- (added) libc/src/math/fsqrtf16.h (+21)
- (modified) libc/src/math/generic/CMakeLists.txt (+10)
- (added) libc/src/math/generic/fsqrtf16.cpp (+21)
- (modified) libc/test/src/math/CMakeLists.txt (+13)
- (added) libc/test/src/math/fsqrtf16_test.cpp (+13)
- (modified) libc/test/src/math/smoke/CMakeLists.txt (+11)
- (added) libc/test/src/math/smoke/fsqrtf16_test.cpp (+13)
- (modified) utils/bazel/llvm-project-overlay/libc/BUILD.bazel (+7)
- (modified) utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel (+5)
``````````diff
diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt
index 291d86b4dd587..25d62ef636710 100644
--- a/libc/config/gpu/amdgpu/entrypoints.txt
+++ b/libc/config/gpu/amdgpu/entrypoints.txt
@@ -562,6 +562,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
libc.src.math.frexpf16
libc.src.math.fromfpf16
libc.src.math.fromfpxf16
+ libc.src.math.fsqrtf16
libc.src.math.getpayloadf16
libc.src.math.ilogbf16
libc.src.math.ldexpf16
diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt
index 1ea0d9b03b37e..4783a6e4e3f96 100644
--- a/libc/config/gpu/nvptx/entrypoints.txt
+++ b/libc/config/gpu/nvptx/entrypoints.txt
@@ -564,6 +564,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
libc.src.math.frexpf16
libc.src.math.fromfpf16
libc.src.math.fromfpxf16
+ libc.src.math.fsqrtf16
libc.src.math.getpayloadf16
libc.src.math.ilogbf16
libc.src.math.ldexpf16
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index c7beb3ef3fdfc..c1d1df48b5903 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -690,6 +690,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
libc.src.math.frexpf16
libc.src.math.fromfpf16
libc.src.math.fromfpxf16
+ libc.src.math.fsqrtf16
libc.src.math.getpayloadf16
libc.src.math.ilogbf16
libc.src.math.iscanonicalf16
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 12dc87bf945fd..baee241ed827e 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -700,6 +700,7 @@ if(LIBC_TYPES_HAS_FLOAT16)
libc.src.math.frexpf16
libc.src.math.fromfpf16
libc.src.math.fromfpxf16
+ libc.src.math.fsqrtf16
libc.src.math.getpayloadf16
libc.src.math.ilogbf16
libc.src.math.iscanonicalf16
diff --git a/libc/docs/headers/math/index.rst b/libc/docs/headers/math/index.rst
index 5b855ce4881c3..c178de620da95 100644
--- a/libc/docs/headers/math/index.rst
+++ b/libc/docs/headers/math/index.rst
@@ -303,7 +303,7 @@ Higher Math Functions
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
| f16sqrt | |check|\* | |check|\* | |check|\* | N/A | |check| | 7.12.14.6 | F.10.11 |
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
-| fsqrt | N/A | |check| | |check| | N/A | |check|\* | 7.12.14.6 | F.10.11 |
+| fsqrt | N/A | |check| | |check| | |check| | |check|\* | 7.12.14.6 | F.10.11 |
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
| hypot | |check| | |check| | | | | 7.12.7.4 | F.10.4.4 |
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
diff --git a/libc/include/math.yaml b/libc/include/math.yaml
index a66f981030864..4f0a1a57899ef 100644
--- a/libc/include/math.yaml
+++ b/libc/include/math.yaml
@@ -1291,6 +1291,13 @@ functions:
return_type: float
arguments:
- type: long double
+ - name: fsqrtf16
+ standards:
+ - stdc
+ return_type: _Float16
+ arguments:
+ - type: _Float16
+ guard: LIBC_TYPES_HAS_FLOAT16
- name: fsqrtf128
standards:
- llvm_libc_ext
diff --git a/libc/src/math/CMakeLists.txt b/libc/src/math/CMakeLists.txt
index f18a73d46f9aa..8657c5382c5bc 100644
--- a/libc/src/math/CMakeLists.txt
+++ b/libc/src/math/CMakeLists.txt
@@ -170,6 +170,7 @@ add_math_entrypoint_object(f16sqrtf128)
add_math_entrypoint_object(fsqrt)
add_math_entrypoint_object(fsqrtl)
+add_math_entrypoint_object(fsqrtf16)
add_math_entrypoint_object(fsqrtf128)
add_math_entrypoint_object(f16sub)
diff --git a/libc/src/math/fsqrtf16.h b/libc/src/math/fsqrtf16.h
new file mode 100644
index 0000000000000..ced9a463d1bc0
--- /dev/null
+++ b/libc/src/math/fsqrtf16.h
@@ -0,0 +1,21 @@
+//===-- Implementation header for fsqrtf16 ----------------------*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#ifndef LLVM_LIBC_SRC_MATH_FSQRTF16_H
+#define LLVM_LIBC_SRC_MATH_FSQRTF16_H
+
+#include "src/__support/macros/config.h"
+#include "src/__support/macros/properties/types.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+float16 fsqrtf16(float16 x);
+
+} // namespace LIBC_NAMESPACE_DECL
+
+#endif // LLVM_LIBC_SRC_MATH_FSQRTF16_H
diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt
index 3114289bad486..2438fec140913 100644
--- a/libc/src/math/generic/CMakeLists.txt
+++ b/libc/src/math/generic/CMakeLists.txt
@@ -4748,6 +4748,16 @@ add_entrypoint_object(
libc.src.__support.FPUtil.generic.sqrt
)
+add_entrypoint_object(
+ fsqrtf16
+ SRCS
+ fsqrtf16.cpp
+ HDRS
+ ../fsqrtf16.h
+ DEPENDS
+ libc.src.__support.FPUtil.generic.sqrt
+)
+
add_entrypoint_object(
fsqrtf128
SRCS
diff --git a/libc/src/math/generic/fsqrtf16.cpp b/libc/src/math/generic/fsqrtf16.cpp
new file mode 100644
index 0000000000000..9fb7ec606246f
--- /dev/null
+++ b/libc/src/math/generic/fsqrtf16.cpp
@@ -0,0 +1,21 @@
+//===-- Implementation of fsqrtf16 function -------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "src/math/fsqrtf16.h"
+#include "src/__support/FPUtil/generic/sqrt.h"
+#include "src/__support/common.h"
+#include "src/__support/macros/config.h"
+#include "src/__support/macros/properties/types.h"
+
+namespace LIBC_NAMESPACE_DECL {
+
+LLVM_LIBC_FUNCTION(float16, fsqrtf16, (float16 x)) {
+ return fputil::sqrt<float16>(x);
+}
+
+} // namespace LIBC_NAMESPACE_DECL
diff --git a/libc/test/src/math/CMakeLists.txt b/libc/test/src/math/CMakeLists.txt
index 53ddd301900c0..6ffe472ace3e8 100644
--- a/libc/test/src/math/CMakeLists.txt
+++ b/libc/test/src/math/CMakeLists.txt
@@ -2567,6 +2567,19 @@ add_fp_unittest(
libc.src.math.fsqrt
)
+add_fp_unittest(
+ fsqrtf16_test
+ NEED_MPFR
+ SUITE
+ libc-math-unittests
+ SRCS
+ fsqrtf16_test.cpp
+ HDRS
+ SqrtTest.h
+ DEPENDS
+ libc.src.math.fsqrtf16
+)
+
add_fp_unittest(
fsqrtl_test
NEED_MPFR
diff --git a/libc/test/src/math/fsqrtf16_test.cpp b/libc/test/src/math/fsqrtf16_test.cpp
new file mode 100644
index 0000000000000..e4dc4f68f4ef9
--- /dev/null
+++ b/libc/test/src/math/fsqrtf16_test.cpp
@@ -0,0 +1,13 @@
+//===-- Unittests for fsqrtf16 --------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "SqrtTest.h"
+
+#include "src/math/fsqrtf16.h"
+
+LIST_NARROWING_SQRT_TESTS(float16, float16, LIBC_NAMESPACE::fsqrtf16)
diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt
index 6f94440d826d9..ab4e125e67f5c 100644
--- a/libc/test/src/math/smoke/CMakeLists.txt
+++ b/libc/test/src/math/smoke/CMakeLists.txt
@@ -4878,6 +4878,17 @@ add_fp_unittest(
libc.src.math.fsqrt
)
+add_fp_unittest(
+ fsqrtf16_test
+ SUITE
+ libc-math-smoke-tests
+ SRCS
+ fsqrtf16_test.cpp
+ HDRS
+ SqrtTest.h
+ DEPENDS
+ libc.src.math.fsqrtf16
+)
add_fp_unittest(
fsqrtl_test
diff --git a/libc/test/src/math/smoke/fsqrtf16_test.cpp b/libc/test/src/math/smoke/fsqrtf16_test.cpp
new file mode 100644
index 0000000000000..e4dc4f68f4ef9
--- /dev/null
+++ b/libc/test/src/math/smoke/fsqrtf16_test.cpp
@@ -0,0 +1,13 @@
+//===-- Unittests for fsqrtf16 --------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "SqrtTest.h"
+
+#include "src/math/fsqrtf16.h"
+
+LIST_NARROWING_SQRT_TESTS(float16, float16, LIBC_NAMESPACE::fsqrtf16)
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index 757db65ca8a77..4c63746ea4af5 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -3023,6 +3023,13 @@ libc_math_function(
],
)
+libc_math_function(
+ name = "fsqrtf16",
+ additional_deps = [
+ ":__support_fputil_sqrt",
+ ],
+)
+
libc_math_function(name = "fsub")
libc_math_function(name = "fsubl")
diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
index 803548178b0e3..c48177d2748ea 100644
--- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel
@@ -257,6 +257,11 @@ math_test(
hdrs = ["SqrtTest.h"],
)
+math_test(
+ name = "fsqrtf16",
+ hdrs = ["SqrtTest.h"],
+)
+
math_test(
name = "dsqrtl",
hdrs = ["SqrtTest.h"],
``````````
</details>
https://github.com/llvm/llvm-project/pull/131153
More information about the llvm-commits
mailing list