[llvm] [llvm][yaml2obj] Modify section header overriding timing (PR #130942)

[James Henderson via llvm-commits]

================
@@ -899,12 +903,17 @@ void ELFState<ELFT>::initSectionHeaders(std::vector<Elf_Shdr> &SHeaders,
     }
 
     LocationCounter += SHeader.sh_size;
-
-    // Override section fields if requested.
-    overrideFields<ELFT>(Sec, SHeader);
+    SectionHeadersOverrideHelper.push_back({SN2I.get(Sec->Name), *Sec});
   }
 }
 
+template <class ELFT>
+void ELFState<ELFT>::overrideSectionHeaders(std::vector<Elf_Shdr> &SHeaders) {
+  for (std::pair<unsigned, ELFYAML::Section> &IndexAndSec :
+       SectionHeadersOverrideHelper)
+    overrideFields<ELFT>(&IndexAndSec.second, SHeaders[IndexAndSec.first]);
----------------
jh7370 wrote:

I think it would just be simpler to update the `overrideFields` function to take the vector of pairs and iterate it over it inside the function, rather than have this additional function. If you want to rename it to `overrideSectionHeaders` for additional clarity, I'm not opposed to that.

https://github.com/llvm/llvm-project/pull/130942