[llvm] [llvm][lit] fix writing results to file (PR #130845)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 13 00:58:52 PDT 2025
jh7370 wrote:
@da-viper, sorry I didn't raise this before, but I just realised that you've got your email address marked as private in GitHub, which means we can't merge this per LLVM policy. See https://llvm.org/docs/DeveloperPolicy.html#email-addresses.
Also, I forgot to comment on your PR description/title, since those form the final commit message once this is merged. Since this PR is specific to a particular option, I suggest mentioning that in the title, e.g. "fix writing results to --time-trace file" (I can't remember the actual option name, please use the correct one!). In the description, you don't need to repeat what's in the title, but I'd suggest you add a reference to the commit that caused the issue (i.e. something like "This patch fixes an issue introduced with 8507dba.")
Let me know once you've addressed these issues and I'll click the merge button. (NB: if this doesn't happen by about 4pm GMT today, I'll not see your comment and am then off work for 2+ weeks, so you'll need to ask somebody else to merge the PR).
https://github.com/llvm/llvm-project/pull/130845
More information about the llvm-commits
mailing list