[llvm] [ELFObject] Added conditions to print removed symbols and removed sections (PR #124692)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 11 03:15:12 PDT 2025
jh7370 wrote:
Hi @kshitijvp, please avoid force pushing to active PRs. It's generally not needed - use a merge commit from `main` if you need to rebase, or do fixup commits (these will disappear when the PR is squashed and merged) and makes reviewing harder, because it trashes the "view changes since last review" option. The LLVM guidelines advise against it too. Also, please don't resolve conversations I've initiated. I use these to check through changes I've requested to ensure you've made the change I asked you to make and marking them as resolved makes it hard to see which ones I've confirmed and which ones I haven't yet (there's a whole discussion on the LLVM forums about the topic).
I've made some comments on the original issue, having given the topic some more though. You might want to pause further work on this PR until we've come to a conclusion there. You could implement the `--verbose` option first as just printing the input files, per the current GNU behaviour. This is definitely going to be wanted and is uncontroversial.
https://github.com/llvm/llvm-project/pull/124692
More information about the llvm-commits
mailing list