[llvm] [RISCV] Sink hasSideEffects, mayLoad, mayStore from defs to classes in RISCVInstrInfo.td. NFC (PR #130714)

[Craig Topper via llvm-commits]

topperc wrote:

> I'm only really in favour of this for consistency, I do think it means you need to look at several different files to work out if you marked your instructions correctly (or just run tablegen to get the elaborated output), and as with CV_INSERTR there's always functions which you end up annotating anyway.

I do wonder if these flags are providing any value. Tablegen can infer them from single instruction patterns in many cases.

https://github.com/llvm/llvm-project/pull/130714