[llvm] [RISCV] Sink hasSideEffects, mayLoad, mayStore from defs to classes in RISCVInstrInfo.td. NFC (PR #130714)
Sam Elliott via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 10 21:14:24 PDT 2025
https://github.com/lenary approved this pull request.
Some nits - I think you can maybe push things higher in the classes in some places, and from lets to inside the classes in others. I likely haven't captured everywhere this is possible.
I'm only really in favour of this for consistency, I do think it means you need to look at several different files to work out if you marked your instructions correctly (or just run tablegen to get the elaborated output), and as with `CV_INSERTR` there's always functions which you end up annotating anyway.
https://github.com/llvm/llvm-project/pull/130714
More information about the llvm-commits
mailing list