[llvm] [WindowsDriver] Always consider `WinSdkVersion` (PR #130377)

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 10 17:48:58 PDT 2025


================
@@ -444,6 +444,13 @@ bool getWindowsSDKDir(vfs::FileSystem &VFS, std::optional<StringRef> WinSdkDir,
     return !WindowsSDKLibVersion.empty();
   }
   if (Major == 10) {
+    if (WinSdkVersion) {
+      // Use the user-provided version as-is.
+      WindowsSDKIncludeVersion = WinSdkVersion->str();
+      WindowsSDKLibVersion = WindowsSDKIncludeVersion;
+      return true;
+    }
----------------
compnerd wrote:

Okay, in the command line handling, the SDK Version is just parsed into major and version and the version is returned. Because of the naming for Win8 SDKs, that is not really useful.

https://github.com/llvm/llvm-project/pull/130377


More information about the llvm-commits mailing list