[llvm] 4508d6a - [AArch64][ELF Parser] Fix out-of-scope variable usage (#130576)

[via llvm-commits]

Author: SivanShani-Arm
Date: 2025-03-10T12:25:40Z
New Revision: 4508d6aa72b0f31056ae01aff0e8009a252e4683

URL: https://github.com/llvm/llvm-project/commit/4508d6aa72b0f31056ae01aff0e8009a252e4683
DIFF: https://github.com/llvm/llvm-project/commit/4508d6aa72b0f31056ae01aff0e8009a252e4683.diff

LOG: [AArch64][ELF Parser] Fix out-of-scope variable usage (#130576)

Return a reference to a persistent variable instead of a temporary copy.

Added: 
    

Modified: 
    llvm/lib/Support/ELFAttrParserExtended.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/ELFAttrParserExtended.cpp b/llvm/lib/Support/ELFAttrParserExtended.cpp
index 44f86a38ef8c2..f8a6f46360dec 100644
--- a/llvm/lib/Support/ELFAttrParserExtended.cpp
+++ b/llvm/lib/Support/ELFAttrParserExtended.cpp
@@ -32,9 +32,9 @@ ELFExtendedAttrParser::getAttributeValue(unsigned Tag) const {
 std::optional<unsigned>
 ELFExtendedAttrParser::getAttributeValue(StringRef BuildAttrSubsectionName,
                                          unsigned Tag) const {
-  for (auto SubSection : SubSectionVec) {
+  for (const auto &SubSection : SubSectionVec) {
     if (BuildAttrSubsectionName == SubSection.Name)
-      for (auto BAItem : SubSection.Content) {
+      for (const auto &BAItem : SubSection.Content) {
         if (Tag == BAItem.Tag)
           return std::optional<unsigned>(BAItem.IntValue);
       }