[lld] [llvm] [readobj][Arm][AArch64] Refactor Build Attributes parsing under ELFAtributeParser and add support for AArch64 Build Attributes (PR #128727)

Mon Mar 10 03:50:32 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ppc64le-lld-multistage-test` running on `ppc64le-lld-multistage-test` while building `llvm` at step 12 "build-stage2-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/9551

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 12 (build-stage2-unified-tree) failure: build (failure)
...
6.702 [6111/170/203] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/TypeTableCollection.cpp.o
6.721 [6111/169/204] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/BinaryStreamReader.cpp.o
6.754 [6111/168/205] Building CXX object unittests/Demangle/CMakeFiles/DemangleTests.dir/RustDemangleTest.cpp.o
6.802 [6111/167/206] Building CXX object unittests/Demangle/CMakeFiles/DemangleTests.dir/OutputBufferTest.cpp.o
6.834 [6111/166/207] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Memory.cpp.o
6.849 [6111/165/208] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Debug.cpp.o
6.883 [6111/164/209] Building CXX object unittests/Demangle/CMakeFiles/DemangleTests.dir/PartialDemangleTest.cpp.o
6.920 [6111/163/210] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/TypeHashing.cpp.o
6.944 [6111/162/211] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/TarWriter.cpp.o
7.027 [6111/161/212] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/ELFAttrParserExtended.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/ELFAttrParserExtended.cpp.o 
ccache /home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/install/stage1/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/build/stage2/lib/Support -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/lib/Support -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/build/stage2/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Werror=global-constructors -O3 -DNDEBUG -std=c++17 -UNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/ELFAttrParserExtended.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/ELFAttrParserExtended.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/ELFAttrParserExtended.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/lib/Support/ELFAttrParserExtended.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-lld-multistage-test/ppc64le-lld-multistage-test/llvm-project/llvm/lib/Support/ELFAttrParserExtended.cpp:60:43: error: address of stack memory associated with local variable 'BAItem' returned [-Werror,-Wreturn-stack-address]
   60 |           return std::optional<StringRef>(BAItem.StringValue);
      |                                           ^~~~~~
1 error generated.
7.059 [6111/160/213] Building CXX object third-party/benchmark/src/CMakeFiles/benchmark.dir/benchmark_register.cc.o
7.065 [6111/159/214] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/FileOutputBuffer.cpp.o
7.084 [6111/158/215] Building CXX object lib/Telemetry/CMakeFiles/LLVMTelemetry.dir/Telemetry.cpp.o
7.127 [6111/157/216] Building CXX object lib/Option/CMakeFiles/LLVMOption.dir/Option.cpp.o
7.141 [6111/156/217] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/TrieRawHashMap.cpp.o
7.162 [6111/155/218] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/DataExtractor.cpp.o
7.194 [6111/154/219] Building CXX object tools/llvm-undname/CMakeFiles/llvm-undname.dir/llvm-undname.cpp.o
7.205 [6111/153/220] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/SuffixTree.cpp.o
7.210 [6111/152/221] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/FormatVariadic.cpp.o
7.227 [6111/151/222] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/SymbolSerializer.cpp.o
7.259 [6111/150/223] Building CXX object unittests/Demangle/CMakeFiles/DemangleTests.dir/DemangleTest.cpp.o
7.262 [6111/149/224] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/DebugCrossExSubsection.cpp.o
7.282 [6111/148/225] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/WithColor.cpp.o
7.293 [6111/147/226] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/APFixedPoint.cpp.o
7.316 [6111/146/227] Building CXX object lib/TableGen/CMakeFiles/LLVMTableGen.dir/TableGenBackendSkeleton.cpp.o
7.329 [6111/145/228] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/ClangASTPropertiesEmitter.cpp.o
7.385 [6111/144/229] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/LockFileManager.cpp.o
7.401 [6111/143/230] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/DebugFrameDataSubsection.cpp.o
7.411 [6111/142/231] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/UnicodeNameToCodepoint.cpp.o
7.527 [6111/141/232] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/DAGDeltaAlgorithm.cpp.o
7.531 [6111/140/233] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/DebugInlineeLinesSubsection.cpp.o
7.532 [6111/139/234] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/DebugSubsectionVisitor.cpp.o
7.555 [6111/138/235] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/DebugStringTableSubsection.cpp.o
7.558 [6111/137/236] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Caching.cpp.o
7.628 [6111/136/237] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/MemoryBuffer.cpp.o
7.633 [6111/135/238] Building CXX object unittests/Support/DynamicLibrary/CMakeFiles/DynamicLibraryTests.dir/DynamicLibraryTest.cpp.o
7.634 [6111/134/239] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/CachePruning.cpp.o
7.650 [6111/133/240] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/AppendingTypeTableBuilder.cpp.o
7.655 [6111/132/241] Building CXX object utils/yaml-bench/CMakeFiles/yaml-bench.dir/YAMLBench.cpp.o
7.668 [6111/131/242] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/raw_socket_stream.cpp.o
7.723 [6111/130/243] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/FileCollector.cpp.o
7.756 [6111/129/244] Building CXX object utils/TableGen/Basic/CMakeFiles/obj.LLVMTableGenBasic.dir/SDNodeProperties.cpp.o
7.764 [6111/128/245] Building CXX object lib/DebugInfo/CodeView/CMakeFiles/LLVMDebugInfoCodeView.dir/StringsAndChecksums.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/128727