[llvm] [DebugInfo] Avoid repeated hash lookups (NFC) (PR #128459)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 23 21:19:30 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-debuginfo
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/128459.diff
1 Files Affected:
- (modified) llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp (+2-6)
``````````diff
diff --git a/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp b/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
index 092495e87443c..42da957233667 100644
--- a/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
+++ b/llvm/lib/DebugInfo/LogicalView/Readers/LVDWARFReader.cpp
@@ -565,12 +565,8 @@ LVScope *LVDWARFReader::processOneDie(const DWARFDie &InputDIE, LVScope *Parent,
// Insert the newly created element into the element symbol table. If the
// element is in the list, it means there are previously created elements
// referencing this element.
- if (ElementTable.find(Offset) == ElementTable.end()) {
- // No previous references to this offset.
- ElementTable.emplace(std::piecewise_construct,
- std::forward_as_tuple(Offset),
- std::forward_as_tuple(CurrentElement));
- } else {
+ auto [It, Inserted] = ElementTable.try_emplace(Offset, CurrentElement);
+ if (!Inserted) {
// There are previous references to this element. We need to update the
// element and all the references pointing to this element.
LVElementEntry &Reference = ElementTable[Offset];
``````````
</details>
https://github.com/llvm/llvm-project/pull/128459
More information about the llvm-commits
mailing list