[libcxx] [llvm] [libc++] Diagnose when nullptrs are passed to string APIs (PR #122790)

[Nikolas Klauser via llvm-commits]

================
@@ -1037,13 +1037,14 @@ public:
 #  endif // _LIBCPP_CXX03_LANG
 
   template <__enable_if_t<__is_allocator<_Allocator>::value, int> = 0>
-  _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 basic_string(const _CharT* __s) {
+  _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 basic_string(const _CharT* _LIBCPP_DIAGNOSE_NONNULL __s) {
----------------
philnik777 wrote:

I agree that the name is confusing. As explained below, this doesn't affect optimizations though, which I want to make clear in the name. I don' want someone in the future to make it `[[gnu::nonnull]]`, since that would almost certainly introduce unwanted behaviour. What do you think about `_LIBCPP_DIAGNOSE_NULLPTR`?

https://github.com/llvm/llvm-project/pull/122790