[llvm] a26fd0b - [LivePhysReg] Fix off by 1 error in an assert. NFC (#128379)

via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 22 21:13:50 PST 2025


Author: Craig Topper
Date: 2025-02-22T21:13:46-08:00
New Revision: a26fd0b75f3c277b1b546a1191d8565c53ea644a

URL: https://github.com/llvm/llvm-project/commit/a26fd0b75f3c277b1b546a1191d8565c53ea644a
DIFF: https://github.com/llvm/llvm-project/commit/a26fd0b75f3c277b1b546a1191d8565c53ea644a.diff

LOG: [LivePhysReg] Fix off by 1 error in an assert. NFC (#128379)

Reg should not be equal to the number of registers.

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/LivePhysRegs.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/LivePhysRegs.h b/llvm/include/llvm/CodeGen/LivePhysRegs.h
index 037905119eb22..696e8a0c5dd59 100644
--- a/llvm/include/llvm/CodeGen/LivePhysRegs.h
+++ b/llvm/include/llvm/CodeGen/LivePhysRegs.h
@@ -82,7 +82,7 @@ class LivePhysRegs {
   /// Adds a physical register and all its sub-registers to the set.
   void addReg(MCPhysReg Reg) {
     assert(TRI && "LivePhysRegs is not initialized.");
-    assert(Reg <= TRI->getNumRegs() && "Expected a physical register.");
+    assert(Reg < TRI->getNumRegs() && "Expected a physical register.");
     for (MCPhysReg SubReg : TRI->subregs_inclusive(Reg))
       LiveRegs.insert(SubReg);
   }
@@ -91,7 +91,7 @@ class LivePhysRegs {
   /// super-registers from the set.
   void removeReg(MCPhysReg Reg) {
     assert(TRI && "LivePhysRegs is not initialized.");
-    assert(Reg <= TRI->getNumRegs() && "Expected a physical register.");
+    assert(Reg < TRI->getNumRegs() && "Expected a physical register.");
     for (MCRegAliasIterator R(Reg, TRI, true); R.isValid(); ++R)
       LiveRegs.erase((*R).id());
   }


        


More information about the llvm-commits mailing list