[llvm] [LivePhysReg] Fix off by 1 error in an assert. NFC (PR #128379)

via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 22 17:58:57 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-regalloc

Author: Craig Topper (topperc)

<details>
<summary>Changes</summary>

Pretty sure Reg should not be equal to the number of registers.

---
Full diff: https://github.com/llvm/llvm-project/pull/128379.diff


1 Files Affected:

- (modified) llvm/include/llvm/CodeGen/LivePhysRegs.h (+2-2) 


``````````diff
diff --git a/llvm/include/llvm/CodeGen/LivePhysRegs.h b/llvm/include/llvm/CodeGen/LivePhysRegs.h
index 037905119eb22..696e8a0c5dd59 100644
--- a/llvm/include/llvm/CodeGen/LivePhysRegs.h
+++ b/llvm/include/llvm/CodeGen/LivePhysRegs.h
@@ -82,7 +82,7 @@ class LivePhysRegs {
   /// Adds a physical register and all its sub-registers to the set.
   void addReg(MCPhysReg Reg) {
     assert(TRI && "LivePhysRegs is not initialized.");
-    assert(Reg <= TRI->getNumRegs() && "Expected a physical register.");
+    assert(Reg < TRI->getNumRegs() && "Expected a physical register.");
     for (MCPhysReg SubReg : TRI->subregs_inclusive(Reg))
       LiveRegs.insert(SubReg);
   }
@@ -91,7 +91,7 @@ class LivePhysRegs {
   /// super-registers from the set.
   void removeReg(MCPhysReg Reg) {
     assert(TRI && "LivePhysRegs is not initialized.");
-    assert(Reg <= TRI->getNumRegs() && "Expected a physical register.");
+    assert(Reg < TRI->getNumRegs() && "Expected a physical register.");
     for (MCRegAliasIterator R(Reg, TRI, true); R.isValid(); ++R)
       LiveRegs.erase((*R).id());
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/128379


More information about the llvm-commits mailing list