[llvm] [llvm] DLLExport public methods from SmallVector (PR #127850)

[Vassil Vassilev via llvm-commits]

vgvassilev wrote:

> Before you do any further work on this project, please create a new discourse thread, which explains what the further plan for adding and maintaining these annotations is. There is a bunch of scattered discussion in various random pull requests, like #109702 or #113097. As this will be a sweeping, highly visible change across the entire codebase, it is important to have a central, up-to-date description of what is going on that further PRs can reference, and make sure that people are on board with your methodology before it starts getting implemented.

I will probably leave @compnerd to comment in details. I don’t oppose your suggestion. In fact, multiple RFCs have already covered this topic extensively. However, the pull request discussions reveal that code owners need clarification on certain aspects of the work, which may be too specific or technical to have been fully addressed in the RFCs. I think that also confirms my personal observation that pull requests somehow are lower barrier for the community to engage(?). For instance, we encountered workarounds that initially seemed functional but turned out to be ODR violations. There isn't a clear place to discuss these finer details, as they often pertain to specific files within particular components.

For years, we had the ideas and implementation plan but lacked the humanpower to execute them. Now, with several contributors available to take on the heavy lifting, we have a rare opportunity to move forward. Restarting discussions risks arriving at the same conclusions while potentially losing momentum and delaying this work for yet another N years.

https://github.com/llvm/llvm-project/pull/127850