[llvm] [FlattenCFG] Fix an Imprecise Usage of AA (PR #128117)

[via llvm-commits]

================
@@ -357,8 +357,12 @@ bool FlattenCFGOpt::CompareIfRegionBlock(BasicBlock *Block1, BasicBlock *Block2,
       for (BasicBlock::iterator BI(PBI2), BE(PTI2); BI != BE; ++BI) {
         if (BI->mayReadFromMemory() || BI->mayWriteToMemory()) {
           // Check alias with Head2.
-          if (!AA || !AA->isNoAlias(&*iter1, &*BI))
-            return false;
+          if (AA) {
+            MemoryLocation Loc1 = MemoryLocation::get(&*iter1);
+            MemoryLocation Loc2 = MemoryLocation::get(&*BI);
----------------
Chengjunp wrote:

I have just added a case including this. Yeah, it will crash with my previous implementation. It should work now with my new implementation.

https://github.com/llvm/llvm-project/pull/128117