[llvm] [DirectX] adding support in obj2yaml and yaml2obj to root constants (PR #127840)

Damyan Pepper via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 11:24:10 PST 2025


================
@@ -14,20 +14,18 @@ Parts:
     Size:            24
     RootSignature:
       Version: 2
-      NumParameters: 1
-      RootParametersOffset: 3
       NumStaticSamplers: 4
       StaticSamplersOffset: 5
+      Parameters: []
       AllowInputAssemblerInputLayout: true
----------------
damyanp wrote:

Will not having it hide bugs?  Maybe as an exercise you could try breaking the implementation and see whether or not the tests are able to detect it.  If they do then maybe my concern is unfounded.

https://github.com/llvm/llvm-project/pull/127840


More information about the llvm-commits mailing list