[llvm] b11e1ba - [llvm-readtapi] Avoid repeated hash lookups (NFC) (#128131)

[via llvm-commits]

Author: Kazu Hirata
Date: 2025-02-21T11:09:16-08:00
New Revision: b11e1baf22a4a5d061a112c490f54f5e767f79e4

URL: https://github.com/llvm/llvm-project/commit/b11e1baf22a4a5d061a112c490f54f5e767f79e4
DIFF: https://github.com/llvm/llvm-project/commit/b11e1baf22a4a5d061a112c490f54f5e767f79e4.diff

LOG: [llvm-readtapi] Avoid repeated hash lookups (NFC) (#128131)

Dylibs is a StringMap, which takes StringRef as the key type, so
NormalizedPath.str() is good enough.  We don't need to create a null
terminated string.  Neither do we need to recompute the string length
as part of StringRef construction.

Added: 
    

Modified: 
    llvm/tools/llvm-readtapi/llvm-readtapi.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-readtapi/llvm-readtapi.cpp b/llvm/tools/llvm-readtapi/llvm-readtapi.cpp
index b5574ea41e332..7a8cad56f6f79 100644
--- a/llvm/tools/llvm-readtapi/llvm-readtapi.cpp
+++ b/llvm/tools/llvm-readtapi/llvm-readtapi.cpp
@@ -358,17 +358,19 @@ static void stubifyDirectory(const StringRef InputPath, Context &Ctx) {
     SmallString<PATH_MAX> NormalizedPath(Path);
     replace_extension(NormalizedPath, "");
 
+    auto [It, Inserted] = Dylibs.try_emplace(NormalizedPath.str());
+
     if ((IF->getFileType() == FileType::MachO_DynamicLibrary) ||
         (IF->getFileType() == FileType::MachO_DynamicLibrary_Stub)) {
       OriginalNames[NormalizedPath.c_str()] = IF->getPath();
 
       // Don't add this MachO dynamic library because we already have a
       // text-based stub recorded for this path.
-      if (Dylibs.count(NormalizedPath.c_str()))
+      if (!Inserted)
         continue;
     }
 
-    Dylibs[NormalizedPath.c_str()] = std::move(IF);
+    It->second = std::move(IF);
   }
 
   for (auto &Lib : Dylibs) {