[llvm] [AsmPrinter] Simplify $local after D131429. NFC (PR #128138)

Alexander Richardson via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 21 10:03:59 PST 2025


https://github.com/arichardson approved this pull request.

Ah nice was not aware that this was allowed without checking (I believe there was/is another place I copied this from). 

LGTM. And if this wasn't NFC it would have noticed by the tests.


I can see a few other placs that check for `MAI->hasDotTypeDotSizeDirective()` before calling emitSymbolAttribute(). Should those be simplified as well as part of this PR or as a separate one?

https://github.com/llvm/llvm-project/pull/128138


More information about the llvm-commits mailing list