[llvm] [llvm-dlltool] Implement the --identify option (PR #127465)

Thu Feb 20 14:54:31 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-aarch64-latest-gcc` running on `linaro-flang-aarch64-latest-gcc` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/130/builds/10273

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
35.750 [3968/19/3383] Creating library symlink lib/libLLVMInterfaceStub.so
35.753 [3968/18/3384] Building CXX object tools/mlir/lib/Dialect/Tosa/Transforms/CMakeFiles/obj.MLIRTosaTransforms.dir/TosaProfileCompliance.cpp.o
In file included from ../llvm-project/mlir/lib/Dialect/Tosa/Transforms/TosaProfileCompliance.cpp:9:
../llvm-project/mlir/include/mlir/Dialect/Tosa/IR/TosaProfileCompliance.h: In member function ‘llvm::SmallVector<mlir::tosa::Profile, 12> TosaProfileCompliance::getCooperativeProfiles(mlir::tosa::Extension)’:
../llvm-project/mlir/include/mlir/Dialect/Tosa/IR/TosaProfileCompliance.h:148:3: warning: control reaches end of non-void function [-Wreturn-type]
  148 |   }
      |   ^
35.795 [3962/23/3385] Building CXX object tools/clang/lib/Lex/CMakeFiles/obj.clangLex.dir/LiteralSupport.cpp.o
35.818 [3962/22/3386] Building CXX object tools/mlir/lib/Dialect/Transform/Interfaces/CMakeFiles/obj.MLIRTransformDialectInterfaces.dir/TransformInterfaces.cpp.o
35.841 [3962/21/3387] Linking CXX shared library lib/libLLVMDlltoolDriver.so.21.0git
FAILED: lib/libLLVMDlltoolDriver.so.21.0git 
: && /usr/local/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMDlltoolDriver.so.21.0git -o lib/libLLVMDlltoolDriver.so.21.0git lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/lib:"  lib/libLLVMObject.so.21.0git  lib/libLLVMOption.so.21.0git  lib/libLLVMTargetParser.so.21.0git  lib/libLLVMSupport.so.21.0git  -Wl,-rpath-link,/home/tcwg-buildbot/worker/flang-aarch64-latest-gcc/build/lib && :
/usr/bin/ld: lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o: in function `(anonymous namespace)::doIdentify(llvm::StringRef, bool)':
DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x130): undefined reference to `llvm::identify_magic(llvm::StringRef)'
/usr/bin/ld: DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x554): undefined reference to `llvm::identify_magic(llvm::StringRef)'
/usr/bin/ld: DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0xa68): undefined reference to `llvm::identify_magic(llvm::StringRef)'
collect2: error: ld returned 1 exit status
35.856 [3962/20/3388] Linking CXX shared library lib/libLLVMLibDriver.so.21.0git
35.866 [3962/19/3389] Linking CXX shared library lib/libLLVMXRay.so.21.0git
35.900 [3962/18/3390] Linking CXX shared library lib/libLLVMObjCopy.so.21.0git
35.907 [3962/17/3391] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
35.915 [3962/16/3392] Building CXX object tools/mlir/lib/Dialect/Transform/DebugExtension/CMakeFiles/obj.MLIRTransformDebugExtension.dir/DebugExtension.cpp.o
35.937 [3962/15/3393] Building CXX object tools/mlir/lib/Dialect/Transform/DebugExtension/CMakeFiles/obj.MLIRTransformDebugExtension.dir/DebugExtensionOps.cpp.o
35.942 [3962/14/3394] Linking CXX shared library lib/libLLVMRuntimeDyld.so.21.0git
35.951 [3962/13/3395] Linking CXX shared library lib/libLLVMDebugInfoDWARF.so.21.0git
35.973 [3962/12/3396] Building CXX object tools/mlir/lib/Dialect/Transform/IR/CMakeFiles/obj.MLIRTransformDialect.dir/TransformAttrs.cpp.o
35.986 [3962/11/3397] Building CXX object tools/mlir/lib/Dialect/Transform/IR/CMakeFiles/obj.MLIRTransformDialect.dir/TransformTypes.cpp.o
35.994 [3962/10/3398] Building CXX object tools/mlir/lib/Dialect/Transform/IR/CMakeFiles/obj.MLIRTransformDialect.dir/Utils.cpp.o
35.995 [3962/9/3399] Building CXX object tools/mlir/lib/Dialect/Transform/Interfaces/CMakeFiles/obj.MLIRTransformDialectInterfaces.dir/MatchInterfaces.cpp.o
35.996 [3962/8/3400] Building CXX object tools/mlir/test/lib/Analysis/CMakeFiles/MLIRTestAnalysis.dir/DataFlow/TestSparseBackwardDataFlowAnalysis.cpp.o
36.020 [3962/7/3401] Building CXX object tools/mlir/lib/Conversion/MathToSPIRV/CMakeFiles/obj.MLIRMathToSPIRV.dir/MathToSPIRVPass.cpp.o
36.042 [3962/6/3402] Linking CXX shared library lib/libLLVMObjectYAML.so.21.0git
36.043 [3962/5/3403] Linking CXX shared library lib/libLLVMJITLink.so.21.0git
36.045 [3962/4/3404] Linking CXX shared library lib/libLLVMDebugInfoPDB.so.21.0git
36.226 [3962/3/3405] Building CXX object tools/clang/lib/StaticAnalyzer/Core/CMakeFiles/obj.clangStaticAnalyzerCore.dir/BugReporter.cpp.o
../llvm-project/clang/lib/StaticAnalyzer/Core/BugReporter.cpp: In function ‘void resetDiagnosticLocationToMainFile(clang::ento::PathDiagnostic&)’:
../llvm-project/clang/lib/StaticAnalyzer/Core/BugReporter.cpp:3346:24: warning: possibly dangling reference to a temporary [-Wdangling-reference]
 3346 |   const SourceManager &SMgr = LastP->getLocation().getManager();
      |                        ^~~~
../llvm-project/clang/lib/StaticAnalyzer/Core/BugReporter.cpp:3346:62: note: the temporary was destroyed at the end of the full expression ‘LastP->clang::ento::PathDiagnosticPiece::getLocation().clang::ento::PathDiagnosticLocation::getManager()’
 3346 |   const SourceManager &SMgr = LastP->getLocation().getManager();
      |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
36.242 [3962/2/3406] Building CXX object tools/clang/lib/Tooling/CMakeFiles/obj.clangTooling.dir/CommonOptionsParser.cpp.o
41.416 [3962/1/3407] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
In file included from ../llvm-project/llvm/include/llvm/LTO/LTO.h:32,
                 from ../llvm-project/llvm/lib/LTO/LTO.cpp:13:
../llvm-project/llvm/include/llvm/Transforms/IPO/FunctionImport.h: In constructor ‘llvm::FunctionImporter::ImportListsTy::ImportListsTy()’:
../llvm-project/llvm/include/llvm/Transforms/IPO/FunctionImport.h:273:33: warning: member ‘llvm::FunctionImporter::ImportListsTy::ImportIDs’ is used uninitialized [-Wuninitialized]
  273 |     ImportListsTy() : EmptyList(ImportIDs) {}

```

</details>

https://github.com/llvm/llvm-project/pull/127465