[llvm] [llvm-dlltool] Implement the --identify option (PR #127465)

Thu Feb 20 14:54:29 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/1253

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[4963/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ExternalASTMerger.cpp.o
[4964/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/FormatString.cpp.o
[4965/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/CommentSema.cpp.o
[4966/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ExprConstant.cpp.o
[4967/7657] Creating library symlink lib/libMLIRVectorToSCF.so
[4968/7657] Linking CXX shared library lib/libMLIRSPIRVConversion.so.21.0git
[4969/7657] Creating library symlink lib/libMLIRSPIRVTarget.so
[4970/7657] Creating library symlink lib/libMLIRSPIRVConversion.so
[4971/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseStmt.cpp.o
[4972/7657] Linking CXX shared library lib/libLLVMDlltoolDriver.so.21.0git
FAILED: lib/libLLVMDlltoolDriver.so.21.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMDlltoolDriver.so.21.0git -o lib/libLLVMDlltoolDriver.so.21.0git lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib:"  lib/libLLVMObject.so.21.0git  lib/libLLVMOption.so.21.0git  lib/libLLVMTargetParser.so.21.0git  lib/libLLVMSupport.so.21.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib && :
/usr/bin/ld: lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o: in function `(anonymous namespace)::doIdentify(llvm::StringRef, bool)':
DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x144): undefined reference to `llvm::identify_magic(llvm::StringRef)'
/usr/bin/ld: DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x9e7): undefined reference to `llvm::identify_magic(llvm::StringRef)'
collect2: error: ld returned 1 exit status
[4973/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseTentative.cpp.o
[4974/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseOpenACC.cpp.o
[4975/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/InheritViz.cpp.o
[4976/7657] Linking CXX shared library lib/libLLVMXRay.so.21.0git
[4977/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ByteCode/BitcastBuffer.cpp.o
[4978/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseTemplate.cpp.o
[4979/7657] Linking CXX shared library lib/libLLVMLibDriver.so.21.0git
[4980/7657] Linking CXX shared library lib/libLLVMInterfaceStub.so.21.0git
[4981/7657] Linking CXX shared library lib/libLLVMRuntimeDyld.so.21.0git
[4982/7657] Linking CXX shared library lib/libMLIRSCFTestPasses.so.21.0git
[4983/7657] Linking CXX shared library lib/libLLVMObjCopy.so.21.0git
[4984/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseStmtAsm.cpp.o
[4985/7657] Linking CXX shared library lib/libLLVMDebugInfoDWARF.so.21.0git
[4986/7657] Linking CXX shared library lib/libLLVMJITLink.so.21.0git
[4987/7657] Building AMDGPUGenMCCodeEmitter.inc...
[4988/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/Parser.cpp.o
[4989/7657] Linking CXX shared library lib/libLLVMDebugInfoPDB.so.21.0git
[4990/7657] Linking CXX shared library lib/libLLVMObjectYAML.so.21.0git
[4991/7657] Linking CXX shared library lib/libMLIRMathToSPIRV.so.21.0git
[4992/7657] Linking CXX shared library lib/libMLIRComplexToSPIRV.so.21.0git
[4993/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/Expr.cpp.o
[4994/7657] Building AMDGPUGenSearchableTables.inc...
[4995/7657] Linking CXX shared library lib/libMLIRLinalgTransforms.so.21.0git
[4996/7657] Building AMDGPUGenDisassemblerTables.inc...
[4997/7657] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[4998/7657] Building AMDGPUGenGlobalISel.inc...
[4999/7657] Building AMDGPUGenAsmWriter.inc...
[5000/7657] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5001/7657] Building AMDGPUGenAsmMatcher.inc...
[5002/7657] Building AMDGPUGenInstrInfo.inc...
[5003/7657] Building AMDGPUGenDAGISel.inc...
[5004/7657] Building AMDGPUGenRegisterBank.inc...
[5005/7657] Building AMDGPUGenRegisterInfo.inc...
Step 7 (build cmake config) failure: build cmake config (failure)
...
[4963/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ExternalASTMerger.cpp.o
[4964/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/FormatString.cpp.o
[4965/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/CommentSema.cpp.o
[4966/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ExprConstant.cpp.o
[4967/7657] Creating library symlink lib/libMLIRVectorToSCF.so
[4968/7657] Linking CXX shared library lib/libMLIRSPIRVConversion.so.21.0git
[4969/7657] Creating library symlink lib/libMLIRSPIRVTarget.so
[4970/7657] Creating library symlink lib/libMLIRSPIRVConversion.so
[4971/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseStmt.cpp.o
[4972/7657] Linking CXX shared library lib/libLLVMDlltoolDriver.so.21.0git
FAILED: lib/libLLVMDlltoolDriver.so.21.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMDlltoolDriver.so.21.0git -o lib/libLLVMDlltoolDriver.so.21.0git lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib:"  lib/libLLVMObject.so.21.0git  lib/libLLVMOption.so.21.0git  lib/libLLVMTargetParser.so.21.0git  lib/libLLVMSupport.so.21.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib && :
/usr/bin/ld: lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o: in function `(anonymous namespace)::doIdentify(llvm::StringRef, bool)':
DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x144): undefined reference to `llvm::identify_magic(llvm::StringRef)'
/usr/bin/ld: DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x9e7): undefined reference to `llvm::identify_magic(llvm::StringRef)'
collect2: error: ld returned 1 exit status
[4973/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseTentative.cpp.o
[4974/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseOpenACC.cpp.o
[4975/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/InheritViz.cpp.o
[4976/7657] Linking CXX shared library lib/libLLVMXRay.so.21.0git
[4977/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ByteCode/BitcastBuffer.cpp.o
[4978/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseTemplate.cpp.o
[4979/7657] Linking CXX shared library lib/libLLVMLibDriver.so.21.0git
[4980/7657] Linking CXX shared library lib/libLLVMInterfaceStub.so.21.0git
[4981/7657] Linking CXX shared library lib/libLLVMRuntimeDyld.so.21.0git
[4982/7657] Linking CXX shared library lib/libMLIRSCFTestPasses.so.21.0git
[4983/7657] Linking CXX shared library lib/libLLVMObjCopy.so.21.0git
[4984/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseStmtAsm.cpp.o
[4985/7657] Linking CXX shared library lib/libLLVMDebugInfoDWARF.so.21.0git
[4986/7657] Linking CXX shared library lib/libLLVMJITLink.so.21.0git
[4987/7657] Building AMDGPUGenMCCodeEmitter.inc...
[4988/7657] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/Parser.cpp.o
[4989/7657] Linking CXX shared library lib/libLLVMDebugInfoPDB.so.21.0git
[4990/7657] Linking CXX shared library lib/libLLVMObjectYAML.so.21.0git
[4991/7657] Linking CXX shared library lib/libMLIRMathToSPIRV.so.21.0git
[4992/7657] Linking CXX shared library lib/libMLIRComplexToSPIRV.so.21.0git
[4993/7657] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/Expr.cpp.o
[4994/7657] Building AMDGPUGenSearchableTables.inc...
[4995/7657] Linking CXX shared library lib/libMLIRLinalgTransforms.so.21.0git
[4996/7657] Building AMDGPUGenDisassemblerTables.inc...
[4997/7657] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
[4998/7657] Building AMDGPUGenGlobalISel.inc...
[4999/7657] Building AMDGPUGenAsmWriter.inc...
[5000/7657] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[5001/7657] Building AMDGPUGenAsmMatcher.inc...
[5002/7657] Building AMDGPUGenInstrInfo.inc...
[5003/7657] Building AMDGPUGenDAGISel.inc...
[5004/7657] Building AMDGPUGenRegisterBank.inc...
[5005/7657] Building AMDGPUGenRegisterInfo.inc...

```

</details>

https://github.com/llvm/llvm-project/pull/127465