[llvm] [llvm-dlltool] Implement the --identify option (PR #127465)

Thu Feb 20 14:53:12 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/1273

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[5753/7657] Building CXX object tools/mlir/test/lib/Dialect/Shape/CMakeFiles/MLIRShapeTestPasses.dir/TestShapeMappingAnalysis.cpp.o
[5754/7657] Building CXX object tools/mlir/test/lib/Dialect/ControlFlow/CMakeFiles/MLIRControlFlowTestPasses.dir/TestAssert.cpp.o
[5755/7657] Building CXX object tools/mlir/test/lib/Dialect/Func/CMakeFiles/MLIRFuncTestPasses.dir/TestDecomposeCallGraphTypes.cpp.o
[5756/7657] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestExpandMath.cpp.o
[5757/7657] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestPolynomialApproximation.cpp.o
[5758/7657] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestAlgebraicSimplification.cpp.o
[5759/7657] Linking CXX shared library lib/libLLVMObjectYAML.so.21.0git
[5760/7657] Linking CXX shared library lib/libLLVMDebugInfoPDB.so.21.0git
[5761/7657] Linking CXX shared library lib/libLLVMJITLink.so.21.0git
[5762/7657] Linking CXX shared library lib/libLLVMDlltoolDriver.so.21.0git
FAILED: lib/libLLVMDlltoolDriver.so.21.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMDlltoolDriver.so.21.0git -o lib/libLLVMDlltoolDriver.so.21.0git lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib:"  lib/libLLVMObject.so.21.0git  lib/libLLVMOption.so.21.0git  lib/libLLVMTargetParser.so.21.0git  lib/libLLVMSupport.so.21.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib && :
lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o: In function `(anonymous namespace)::doIdentify(llvm::StringRef, bool)':
DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x124): undefined reference to `llvm::identify_magic(llvm::StringRef)'
DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x9af): undefined reference to `llvm::identify_magic(llvm::StringRef)'
collect2: error: ld returned 1 exit status
[5763/7657] Linking CXX shared library lib/libMLIRPDLInterpDialect.so.21.0git
[5764/7657] Building CXX object tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSlicing.cpp.o
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/mlir/test/lib/IR/TestSlicing.cpp: In copy constructor ‘{anonymous}::SliceAnalysisTestPass::SliceAnalysisTestPass(const {anonymous}::SliceAnalysisTestPass&)’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/mlir/test/lib/IR/TestSlicing.cpp:70:3: warning: base class ‘class mlir::PassWrapper<{anonymous}::SliceAnalysisTestPass, mlir::OperationPass<mlir::ModuleOp> >’ should be explicitly initialized in the copy constructor [-Wextra]
   SliceAnalysisTestPass(const SliceAnalysisTestPass &) {}
   ^~~~~~~~~~~~~~~~~~~~~
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-deprecated-copy’
[5765/7657] Linking CXX shared library lib/libMLIRPDLLCodeGen.so.21.0git
[5766/7657] Linking CXX shared library lib/libMLIRPluginsLib.so.21.0git
[5767/7657] Building CXX object tools/mlir/test/lib/Dialect/Mesh/CMakeFiles/MLIRMeshTest.dir/TestReshardingSpmdization.cpp.o
[5768/7657] Building CXX object tools/mlir/test/lib/Dialect/NVGPU/CMakeFiles/MLIRNVGPUTestPasses.dir/TestNVGPUTransforms.cpp.o
[5769/7657] Building CXX object tools/mlir/test/lib/Dialect/Mesh/CMakeFiles/MLIRMeshTest.dir/TestSimplifications.cpp.o
[5770/7657] Building CXX object tools/mlir/test/lib/Dialect/Mesh/CMakeFiles/MLIRMeshTest.dir/TestOpLowering.cpp.o
[5771/7657] Building CXX object tools/mlir/test/lib/Dialect/SCF/CMakeFiles/MLIRSCFTestPasses.dir/TestWhileOpBuilder.cpp.o
[5772/7657] Building CXX object tools/mlir/test/lib/Dialect/Shape/CMakeFiles/MLIRShapeTestPasses.dir/TestShapeFunctions.cpp.o
[5773/7657] Building CXX object tools/mlir/test/lib/Dialect/SPIRV/CMakeFiles/MLIRSPIRVTestPasses.dir/TestAvailability.cpp.o
[5774/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestAttributes.cpp.o
[5775/7657] Building CXX object tools/mlir/test/lib/Dialect/Tensor/CMakeFiles/MLIRTensorTestPasses.dir/TestTensorTransforms.cpp.o
[5776/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestFormatUtils.cpp.o
[5777/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestInterfaces.cpp.o
[5778/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestDialect.cpp.o
[5779/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOpDefs.cpp.o
[5780/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.cpp.o
[5781/7657] Creating library symlink lib/libMLIRTransformDialectUtils.so
[5782/7657] Creating library symlink lib/libMLIRUBDialect.so
[5783/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestPatterns.cpp.o
[5784/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestTraits.cpp.o
[5785/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestTypes.cpp.o
[5786/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOpsSyntax.cpp.o
[5787/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestDialectInterfaces.cpp.o
[5788/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.0.cpp.o
[5789/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.1.cpp.o
Step 7 (build cmake config) failure: build cmake config (failure)
...
[5753/7657] Building CXX object tools/mlir/test/lib/Dialect/Shape/CMakeFiles/MLIRShapeTestPasses.dir/TestShapeMappingAnalysis.cpp.o
[5754/7657] Building CXX object tools/mlir/test/lib/Dialect/ControlFlow/CMakeFiles/MLIRControlFlowTestPasses.dir/TestAssert.cpp.o
[5755/7657] Building CXX object tools/mlir/test/lib/Dialect/Func/CMakeFiles/MLIRFuncTestPasses.dir/TestDecomposeCallGraphTypes.cpp.o
[5756/7657] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestExpandMath.cpp.o
[5757/7657] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestPolynomialApproximation.cpp.o
[5758/7657] Building CXX object tools/mlir/test/lib/Dialect/Math/CMakeFiles/MLIRMathTestPasses.dir/TestAlgebraicSimplification.cpp.o
[5759/7657] Linking CXX shared library lib/libLLVMObjectYAML.so.21.0git
[5760/7657] Linking CXX shared library lib/libLLVMDebugInfoPDB.so.21.0git
[5761/7657] Linking CXX shared library lib/libLLVMJITLink.so.21.0git
[5762/7657] Linking CXX shared library lib/libLLVMDlltoolDriver.so.21.0git
FAILED: lib/libLLVMDlltoolDriver.so.21.0git 
: && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMDlltoolDriver.so.21.0git -o lib/libLLVMDlltoolDriver.so.21.0git lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib:"  lib/libLLVMObject.so.21.0git  lib/libLLVMOption.so.21.0git  lib/libLLVMTargetParser.so.21.0git  lib/libLLVMSupport.so.21.0git  -Wl,-rpath-link,/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/build/lib && :
lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.o: In function `(anonymous namespace)::doIdentify(llvm::StringRef, bool)':
DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x124): undefined reference to `llvm::identify_magic(llvm::StringRef)'
DlltoolDriver.cpp:(.text._ZN12_GLOBAL__N_110doIdentifyEN4llvm9StringRefEb+0x9af): undefined reference to `llvm::identify_magic(llvm::StringRef)'
collect2: error: ld returned 1 exit status
[5763/7657] Linking CXX shared library lib/libMLIRPDLInterpDialect.so.21.0git
[5764/7657] Building CXX object tools/mlir/test/lib/IR/CMakeFiles/MLIRTestIR.dir/TestSlicing.cpp.o
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/mlir/test/lib/IR/TestSlicing.cpp: In copy constructor ‘{anonymous}::SliceAnalysisTestPass::SliceAnalysisTestPass(const {anonymous}::SliceAnalysisTestPass&)’:
/home/botworker/bbot/amdgpu-offload-rhel-8-cmake-build-only/llvm-project/mlir/test/lib/IR/TestSlicing.cpp:70:3: warning: base class ‘class mlir::PassWrapper<{anonymous}::SliceAnalysisTestPass, mlir::OperationPass<mlir::ModuleOp> >’ should be explicitly initialized in the copy constructor [-Wextra]
   SliceAnalysisTestPass(const SliceAnalysisTestPass &) {}
   ^~~~~~~~~~~~~~~~~~~~~
At global scope:
cc1plus: warning: unrecognized command line option ‘-Wno-deprecated-copy’
[5765/7657] Linking CXX shared library lib/libMLIRPDLLCodeGen.so.21.0git
[5766/7657] Linking CXX shared library lib/libMLIRPluginsLib.so.21.0git
[5767/7657] Building CXX object tools/mlir/test/lib/Dialect/Mesh/CMakeFiles/MLIRMeshTest.dir/TestReshardingSpmdization.cpp.o
[5768/7657] Building CXX object tools/mlir/test/lib/Dialect/NVGPU/CMakeFiles/MLIRNVGPUTestPasses.dir/TestNVGPUTransforms.cpp.o
[5769/7657] Building CXX object tools/mlir/test/lib/Dialect/Mesh/CMakeFiles/MLIRMeshTest.dir/TestSimplifications.cpp.o
[5770/7657] Building CXX object tools/mlir/test/lib/Dialect/Mesh/CMakeFiles/MLIRMeshTest.dir/TestOpLowering.cpp.o
[5771/7657] Building CXX object tools/mlir/test/lib/Dialect/SCF/CMakeFiles/MLIRSCFTestPasses.dir/TestWhileOpBuilder.cpp.o
[5772/7657] Building CXX object tools/mlir/test/lib/Dialect/Shape/CMakeFiles/MLIRShapeTestPasses.dir/TestShapeFunctions.cpp.o
[5773/7657] Building CXX object tools/mlir/test/lib/Dialect/SPIRV/CMakeFiles/MLIRSPIRVTestPasses.dir/TestAvailability.cpp.o
[5774/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestAttributes.cpp.o
[5775/7657] Building CXX object tools/mlir/test/lib/Dialect/Tensor/CMakeFiles/MLIRTensorTestPasses.dir/TestTensorTransforms.cpp.o
[5776/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestFormatUtils.cpp.o
[5777/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestInterfaces.cpp.o
[5778/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestDialect.cpp.o
[5779/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOpDefs.cpp.o
[5780/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.cpp.o
[5781/7657] Creating library symlink lib/libMLIRTransformDialectUtils.so
[5782/7657] Creating library symlink lib/libMLIRUBDialect.so
[5783/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestPatterns.cpp.o
[5784/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestTraits.cpp.o
[5785/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestTypes.cpp.o
[5786/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOpsSyntax.cpp.o
[5787/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestDialectInterfaces.cpp.o
[5788/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.0.cpp.o
[5789/7657] Building CXX object tools/mlir/test/lib/Dialect/Test/CMakeFiles/MLIRTestDialect.dir/TestOps.1.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/127465