[llvm] [llvm-objdump] Add support for HIP offload bundles (PR #114834)

[Joseph Huber via llvm-commits]

================
@@ -64,6 +68,56 @@ void llvm::dumpOffloadBinary(const ObjectFile &O) {
   // Print out all the binaries that are contained in this buffer.
   for (uint64_t I = 0, E = Binaries.size(); I != E; ++I)
     printBinary(*Binaries[I].getBinary(), I);
+
+  dumpOffloadBundleFatBinary(O, ArchName);
+}
+
+// Given an Object file, collect all Bundles of FatBin Binaries
+// and dump them into Code Object files
+// if -d is specified, disassemble the Code Object Files
+// if -arch=-name is specified, only dump the Entries that match the target arch
+void llvm::dumpOffloadBundleFatBinary(const ObjectFile &O, StringRef ArchName) {
+  assert((O.isELF() || O.isCOFF()) && "Invalid file type");
----------------
jhuber6 wrote:

This should be a warning like it is above, assertions are used for diagnosing invariants and not invalid input. Without an assertions build this check won't exist so someone calling it with a Mach-O file will do something unexpected.

There should also be some tests for these types of warnings / errors. I think all the cases that the existing offload tests cover.

https://github.com/llvm/llvm-project/pull/114834