[llvm] [msan][NFCI] Rename tests and update comment (PR #127926)

Thurston Dang via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 16:51:06 PST 2025


https://github.com/thurstond created https://github.com/llvm/llvm-project/pull/127926

This renames the neon_* tests to be more consistent with the original file that they were forked from.

It also fixes the header comment for llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-vcvt.ll (instrumentation was updated in #126136 aka e9e6ba6a5e2a4ca7386861136196903febb9968b, but the comment was not).

>From 7eca561dd63f2c7ce8ab1858f12ef6c40972b5f4 Mon Sep 17 00:00:00 2001
From: Thurston Dang <thurston at google.com>
Date: Thu, 20 Feb 2025 00:47:17 +0000
Subject: [PATCH] [msan][NFCI] Rename tests and update comment

This renames the neon_* tests to be more consistent with the original
file that they were forked from.

It also fixes the header comment for llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-vcvt.ll (instrumentation was updated in #126136 aka e9e6ba6a5e2a4ca7386861136196903febb9968b, but the comment was not).
---
 .../MemorySanitizer/AArch64/{neon_vst.ll => arm64-st1.ll}   | 0
 .../AArch64/{neon_vst_lane.ll => arm64-st1_lane.ll}         | 0
 .../AArch64/{neon_vst_origins.ll => arm64-st1_origins.ll}   | 0
 .../MemorySanitizer/AArch64/{neon_tbl.ll => arm64-tbl.ll}   | 0
 .../Instrumentation/MemorySanitizer/AArch64/arm64-vcvt.ll   | 6 ------
 .../MemorySanitizer/AArch64/{neon_vmul.ll => arm64-vmul.ll} | 0
 6 files changed, 6 deletions(-)
 rename llvm/test/Instrumentation/MemorySanitizer/AArch64/{neon_vst.ll => arm64-st1.ll} (100%)
 rename llvm/test/Instrumentation/MemorySanitizer/AArch64/{neon_vst_lane.ll => arm64-st1_lane.ll} (100%)
 rename llvm/test/Instrumentation/MemorySanitizer/AArch64/{neon_vst_origins.ll => arm64-st1_origins.ll} (100%)
 rename llvm/test/Instrumentation/MemorySanitizer/AArch64/{neon_tbl.ll => arm64-tbl.ll} (100%)
 rename llvm/test/Instrumentation/MemorySanitizer/AArch64/{neon_vmul.ll => arm64-vmul.ll} (100%)

diff --git a/llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_vst.ll b/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-st1.ll
similarity index 100%
rename from llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_vst.ll
rename to llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-st1.ll
diff --git a/llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_vst_lane.ll b/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-st1_lane.ll
similarity index 100%
rename from llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_vst_lane.ll
rename to llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-st1_lane.ll
diff --git a/llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_vst_origins.ll b/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-st1_origins.ll
similarity index 100%
rename from llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_vst_origins.ll
rename to llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-st1_origins.ll
diff --git a/llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_tbl.ll b/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-tbl.ll
similarity index 100%
rename from llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_tbl.ll
rename to llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-tbl.ll
diff --git a/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-vcvt.ll b/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-vcvt.ll
index 48fe06728b71c..93a75df4b76cc 100644
--- a/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-vcvt.ll
+++ b/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-vcvt.ll
@@ -2,12 +2,6 @@
 ; RUN: opt < %s -passes=msan -S | FileCheck %s
 ;
 ; Suboptimally handled by visitInstruction: llvm.aarch64.neon.
-; - fcvtas, fcvtau
-; - fcvtms, fcvtmu
-; - fcvtns, fcvtnu
-; - fcvtps, fcvtpu
-; - fcvtzs, fcvtzu
-; - fcvtxn
 ; - vcvtfp2fxs, vcvtfp2fxu
 ; - vcvtfxs2fp, vcvtfxu2fp
 ;
diff --git a/llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_vmul.ll b/llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-vmul.ll
similarity index 100%
rename from llvm/test/Instrumentation/MemorySanitizer/AArch64/neon_vmul.ll
rename to llvm/test/Instrumentation/MemorySanitizer/AArch64/arm64-vmul.ll



More information about the llvm-commits mailing list