[lld] [AArch64][GCS][LLD] Introduce -zgcs-report-dynamic Command Line Option (PR #127787)

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 07:07:49 PST 2025


================
@@ -49,25 +49,30 @@
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SetVector.h"
 #include "llvm/ADT/StringExtras.h"
+#include "llvm/ADT/StringRef.h"
----------------
smithp35 wrote:

Out of all these header files I think only SaveAndRestore.h is needed.

Looking at https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible it mentions:
> you can include them either directly or indirectly through another header file

Personally I'd keep changes to a minimum for this patch. If we want to expand all transitive includes then that would be best done in a separate NFC patch. 

https://github.com/llvm/llvm-project/pull/127787


More information about the llvm-commits mailing list